mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: John Mudd <johnbmudd@gmail.com>
Cc: musl <musl@lists.openwall.com>
Subject: Re: posix_fallocate() fails on some machines
Date: Thu, 26 Apr 2018 16:08:25 -0400	[thread overview]
Message-ID: <20180426200825.GL3094@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAGDMk9Fo05xj-Wof6gj-hOO1fuRaQdfurpxguxYppF983mP_kQ@mail.gmail.com>

On Thu, Apr 26, 2018 at 03:54:19PM -0400, John Mudd wrote:
> I built a 32-bit dynamically linked Postgres using musl but I can't run on
> some machines because posix_fallocate() returns 95, "not supported".
> 
> Here's a sample program that reproduces the issue even when compiled
> statically. Any suggestions?
> 
> # Build a 32-bit static executable. Works.
> $ cat test_posix_fallocate.c
> #include <stdio.h>
> #include <fcntl.h>
> int main() {
>     int fd = open("foo", O_RDWR|O_CREAT, 0666);
>     if (fd < 0) return 1;
>     printf("posix_fallocate() returned %d\n", posix_fallocate(fd, 0,
> 400000));
> }
> $
> $ uname -mrs
> Linux 4.4.0-116-generic i686
> $ musl-gcc -static -o test_posix_fallocate test_posix_fallocate.c
> $ test_posix_fallocate
> posix_fallocate() returned 0
> $
> 
> # Copy it to an older OS. Fails.
> $ uname -mrs
> Linux 2.6.32-358.14.1.el6.x86_64 x86_64
> $ test_posix_fallocate
> posix_fallocate() returned 95
> $

This is a bug in postgresql. It must accept that some underlying
filesystems do not support posix_fallocate. The reason it doesn't is
that glibc implements a buggy and dangerous fallback when it's not
supported, resolved WONTFIX:

https://sourceware.org/bugzilla/show_bug.cgi?id=6865

Simply patch postgresql not to consider this a fatal error, or use a
filesystem where posix_fallocate is supported (e.g. ext3/4).

Rich


  reply	other threads:[~2018-04-26 20:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 19:54 John Mudd
2018-04-26 20:08 ` Rich Felker [this message]
2018-04-26 20:21   ` John Mudd
2018-04-26 20:52     ` Rich Felker
2018-04-27 20:01       ` John Mudd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426200825.GL3094@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=johnbmudd@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).