From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12908 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix TLS layout of TLS variant I when there is a gap above TP Date: Mon, 11 Jun 2018 15:14:10 -0400 Message-ID: <20180611191410.GI1392@brightrain.aerifal.cx> References: <20180601235201.GO4418@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1528744340 7969 195.159.176.226 (11 Jun 2018 19:12:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 19:12:20 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12924-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 11 21:12:16 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fSSEh-0001yU-9w for gllmg-musl@m.gmane.org; Mon, 11 Jun 2018 21:12:15 +0200 Original-Received: (qmail 7950 invoked by uid 550); 11 Jun 2018 19:14:24 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7929 invoked from network); 11 Jun 2018 19:14:23 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12908 Archived-At: On Mon, Jun 11, 2018 at 09:02:51PM +0200, Phillip Berndt wrote: > 2018-06-04 9:27 GMT+02:00 Phillip Berndt : > > 2018-06-02 1:52 GMT+02:00 Szabolcs Nagy : > >> The fix required changing TP_ADJ and __pthread_self on affected > >> targets (aarch64, arm and sh) and in the tlsdesc asm the offset to > >> access the dtv changed too. > >> --- > >> passed my simple local-exec tests. > > > > > > Confirmed working on real aarch64, too. Awesome work, thanks a lot! > > > > Got an opportunity to test this on real 32-bit arm hardware, fixes the > issue there for me as well. > > Any news on the review & merge of the patch? Yes, I think it's fine and I've got it queued with a [much longer than I realized! sorry!] batch of commits to push. Will look over things and push asap after checking I didn't do anything stupid aside from leaving them sitting so long. Rich