From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12954 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Package build failure with musl 1.1.19 + Linux 4.14.48 (UAPI?) Date: Tue, 26 Jun 2018 20:51:23 -0400 Message-ID: <20180627005123.GD1392@brightrain.aerifal.cx> References: <8484b2d8-bdec-e84d-c7a1-cdb9112b651f@adelielinux.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1530060571 27174 195.159.176.226 (27 Jun 2018 00:49:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2018 00:49:31 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12970-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 27 02:49:27 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fXyeE-00070G-Up for gllmg-musl@m.gmane.org; Wed, 27 Jun 2018 02:49:27 +0200 Original-Received: (qmail 30196 invoked by uid 550); 27 Jun 2018 00:51:36 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30176 invoked from network); 27 Jun 2018 00:51:35 -0000 Content-Disposition: inline In-Reply-To: <8484b2d8-bdec-e84d-c7a1-cdb9112b651f@adelielinux.org> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12954 Archived-At: On Tue, Jun 26, 2018 at 06:19:49PM -0500, A. Wilcox wrote: > Hi there, > > Attempting to build net-tools 1.60 on musl 1.1.19 with Linux headers > from kernel 4.14.48 installed on a PowerPC computer, we're seeing the > following build error: > > > In file included from /usr/include/linux/if_tunnel.h:7:0, > from iptunnel.c:34: > /usr/include/linux/ip.h:86:8: error: redefinition of ‘struct iphdr’ > struct iphdr { > ^~~~~ > In file included from iptunnel.c:29:0: > /usr/include/netinet/ip.h:25:8: note: originally defined here > struct iphdr { > ^~~~~ > make: *** [Makefile:94: iptunnel.o] Error 1 > > > This failure was not present with kernel headers from 4.4. This may be > a regression in the kernel or it may just be a change that needs to be > made to musl. I am not very experienced in dealing with UAPI and didn't > see much in the kernel doc tree so I was wondering if someone on this > list could point me towards any resources about how to debug/fix such > issues. > > Thank you for your time and attention. The breakage was introduced in 2016 in Linux commit 1fe8e0f074c77aa41aaa579345a9e675acbebfa9. Incidentally, they *knew* this was wrong back in 2009; before the UAPI headers were separated out, commit 0afd4a21ba7d75e93fa79cf05d7a21774e149c0f documents that if if_tunnel.h includes linux/ip.h it will break userspace, and puts it under #ifdef __KERNEL__. Rich