From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13022 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: getaddrinfo(3) / AI_ADDRCONFIG Date: Wed, 11 Jul 2018 13:00:34 -0400 Message-ID: <20180711170034.GY1392@brightrain.aerifal.cx> References: <20180710150854.GU1392@brightrain.aerifal.cx> <20180711003816.GV1392@brightrain.aerifal.cx> <20180711012640.GW1392@brightrain.aerifal.cx> <20180711164417.GX1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1531328327 3386 195.159.176.226 (11 Jul 2018 16:58:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Jul 2018 16:58:47 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-13038-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 11 18:58:43 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fdIRq-0000h5-P1 for gllmg-musl@m.gmane.org; Wed, 11 Jul 2018 18:58:38 +0200 Original-Received: (qmail 4016 invoked by uid 550); 11 Jul 2018 17:00:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 3998 invoked from network); 11 Jul 2018 17:00:46 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:13022 Archived-At: On Wed, Jul 11, 2018 at 12:50:53PM -0400, Christopher Friedt wrote: > On Wed, Jul 11, 2018, 12:44 PM Rich Felker, wrote: > > > On Wed, Jul 11, 2018 at 06:12:31AM -0400, Christopher Friedt wrote: > > > On Tue, Jul 10, 2018 at 9:26 PM Rich Felker wrote: > > > > Pulling in large amounts of additional code and O(n) runtime cost > > > > > > Latest patch [1] addresses > > > > > > 1) not ignoring loopback > > > 2) using routability of udp packets vs O(n) lookup on network interfaces > > > > > > Any other concerns, Rich? > > > > You seem to have deleted the original patch and replaced it with a new > > > > > Some lists prefer patches to be inline. I wasn't sure if you wanted the > attachment. That clarifies that. > > With that said, it still makes sprawling changes and intraduces a > > gratuitous new file with external interface for something that > > fundamentally takes only a few lines in one place and no external > > interface at all. Formatting is also > > > I'll put it directly inside of getaddrinfo. It could probably go inside __lookup_name, but maybe in getaddrinfo is better since that would avoid linking it for gethostbyname, etc. (which don't need it). > inconsistent with musl (spaces > > after opening and before closing paren, etc.). > > > Ok, will reformat. > > And addition of the > > nonstandard EAI_NODATA is an independent change that, if it makes > > sense at all, needs to be discussed > > > Right. What error would you prefer? I think the one mandated by POSIX is EAI_NONAME ("The name does not resolve for the supplied parameters"). Rich