From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13053 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] arm asm for vfork Date: Tue, 17 Jul 2018 22:35:26 -0400 Message-ID: <20180718023526.GO1392@brightrain.aerifal.cx> References: <20180430013622.28792-1-patrick.oppenlander@gmail.com> <20180430013622.28792-2-patrick.oppenlander@gmail.com> <20180430020944.GF1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1531881217 25918 195.159.176.226 (18 Jul 2018 02:33:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2018 02:33:37 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-13069-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 18 04:33:33 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ffcHU-0006dV-2Y for gllmg-musl@m.gmane.org; Wed, 18 Jul 2018 04:33:32 +0200 Original-Received: (qmail 13875 invoked by uid 550); 18 Jul 2018 02:35:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13857 invoked from network); 18 Jul 2018 02:35:39 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:13053 Archived-At: On Wed, Jul 18, 2018 at 12:20:00PM +1000, Patrick Oppenlander wrote: > Hi Rich, > > I saw another thread where it was mentioned you may be doing a 1.20 > release some time soon. > > Is there any chance this could get merged in time? I've been running > it for months without any issues now. > > Attached is an updated patch using svc rather than swi. Thanks. One detail: > diff --git a/src/process/arm/vfork.s b/src/process/arm/vfork.s > new file mode 100644 > index 00000000..db4e7b43 > --- /dev/null > +++ b/src/process/arm/vfork.s > @@ -0,0 +1,12 @@ > +.syntax unified > +.global __vfork > +.weak vfork > +.type __vfork,%function > +.type vfork,%function > +__vfork: > +vfork: > + mov ip, r7 > + mov r7, 190 > + svc 0 > + mov r7, ip > + b __syscall_ret > -- I think there needs to be a ".hidden __syscall_ret" (by de facto musl convention, on the line before it's used) here. It *might* be ok having the reference omit .hidden as long as the definition is hidden at link-time (which it is), but I'm not convinced the tooling won't complain about a branch to a destination that's not known to be link-time constant displacement. If you have no other changes or comments I'm happy to just --amend that into the patch when I commit it. Rich