From: "Fāng-ruì Sòng" <i@maskray.me>
To: musl@lists.openwall.com
Subject: [PATCH] bsearch: simplify and optimize
Date: Sat, 21 Jul 2018 17:47:32 -0700 [thread overview]
Message-ID: <20180722004358.6q7kegg7sx6q2p7e@google.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: bsearch.patch --]
[-- Type: text/x-diff, Size: 906 bytes --]
From 64d86f96fa404dbaa40de8a1979ecadca6add4ca Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Sat, 21 Jul 2018 17:34:00 -0700
Subject: [PATCH] bsearch: simplify and optimize
---
src/stdlib/bsearch.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/stdlib/bsearch.c b/src/stdlib/bsearch.c
index 61d89367..2a998cc6 100644
--- a/src/stdlib/bsearch.c
+++ b/src/stdlib/bsearch.c
@@ -7,14 +7,13 @@ void *bsearch(const void *key, const void *base, size_t nel, size_t width, int (
while (nel > 0) {
try = (char *)base + width*(nel/2);
sign = cmp(key, try);
- if (!sign) return try;
- else if (nel == 1) break;
- else if (sign < 0)
+ if (sign < 0)
nel /= 2;
- else {
- base = try;
- nel -= nel/2;
- }
+ else if (sign > 0) {
+ base = (char *)try + width;
+ nel -= nel/2+1;
+ } else
+ return try;
}
return NULL;
}
--
2.17.1
next reply other threads:[~2018-07-22 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 0:47 Fāng-ruì Sòng [this message]
2018-07-22 18:51 ` Rich Felker
2018-07-22 23:03 ` Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180722004358.6q7kegg7sx6q2p7e@google.com \
--to=i@maskray.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).