From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13119 Path: news.gmane.org!.POSTED!not-for-mail From: Segev Finer Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH 3/3] mipsn32: Call exit on return from fn in __clone Date: Wed, 15 Aug 2018 20:46:20 +0300 Message-ID: <20180815174620.10752-4-segev208@gmail.com> References: <20180815174620.10752-1-segev208@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534371457 16145 195.159.176.226 (15 Aug 2018 22:17:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 22:17:37 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13135-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 16 00:17:33 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fq46d-00043T-Q8 for gllmg-musl@m.gmane.org; Thu, 16 Aug 2018 00:17:31 +0200 Original-Received: (qmail 15684 invoked by uid 550); 15 Aug 2018 22:19:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 1542 invoked from network); 15 Aug 2018 17:46:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=cmOB6Hzh2Ss00Z9X6LwBZnVyu5TC6nM+wa+gHEFTMkg=; b=s5J3kZ8ICdbAjlnkYL1pHR3feXXk15rWv0NGX2ANG3ccBJy6A1ITts5eqpiSzeox8V euGZUSclR6FQIsYecVekIXILfOHYo/d/Y3UP4ZyET1hh9DkuBfE0Pp8NmuCaWostWtl3 SyZTlc77jdH25JL5q5j91TeEifYhyQAGUYSWIYBGBI/FJyv+HiNvx0E+jyrdn1zXoral Rw2FId8rno32FU7Xm28ASVGk2+OrQrCYToLGECgyI7CPSx+u25u6PoPszOL4yUmbzYlv iCSMC/vw5Ql/4gn3euX8v+eyh4cVH0Wf8j3QNTA6UUjehJuGkiWuYoNYz/43sdvdgZJT /dgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=cmOB6Hzh2Ss00Z9X6LwBZnVyu5TC6nM+wa+gHEFTMkg=; b=AmgMjxGn7pxUxx0hR90v9C+s7XbKyWSu+BI025HBEFhtyflo0/Deq9nzceRQUeyk7g /dNJSkFc9PHNBg3qL05O/FdFJa43SNpZkDFXGku9DwqCv8OomHiAKGCH1fwZOndY1NzF kK7U1zLaG6Z9TCrQqBjm5xiyPSvDJKBOmtFYJkjWHnM+7viGvGnnHbHtgRmgs87/t3NS L7uXbqk3ROp1zUz35pn0g32oX6CZNJS53SOXrTIMkteXU6DciPZ8zbKdignQwVKcT4SH subKmXrcMEBzjGY7JJYVcRbTnFNBB4yrWvXK729HVbSorzpB6FBrQyMe3Aq4eXe9aNb2 YWUA== X-Gm-Message-State: AOUpUlEJAOXY4cW+Qm4mmSp1hM6XAuK+2Zu7M4xab5ccKarlhZ9yvll8 8lKt+q45ZntaWw9OB6PPv99ga1mZW9M= X-Google-Smtp-Source: AA+uWPxbB8z+1GjMdbgyZbVaWT0LMvqmk3nO9FrGjJTAxvWh4Ta4ilvs+xwigyApSi5N1qlyYMqZ/Q== X-Received: by 2002:adf:e749:: with SMTP id c9-v6mr16359059wrn.143.1534355193790; Wed, 15 Aug 2018 10:46:33 -0700 (PDT) X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180815174620.10752-1-segev208@gmail.com> Xref: news.gmane.org gmane.linux.lib.musl.general:13119 Archived-At: This is the expected behavior of this function. Without this the child task will crash on return from fn, since it will return to nowhere. --- src/thread/mipsn32/clone.s | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/thread/mipsn32/clone.s b/src/thread/mipsn32/clone.s index 51035852..ebf5dbea 100644 --- a/src/thread/mipsn32/clone.s +++ b/src/thread/mipsn32/clone.s @@ -26,5 +26,8 @@ __clone: nop 1: lw $25, 0($sp) # function pointer lw $4, 4($sp) # argument pointer - jr $25 # call the user's function + jalr $25 # call the user's function nop + move $4, $2 + li $2, 6058 + syscall -- 2.18.0