From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13123 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 0/3] mips{,64,n32}: Call exit on return from fn in __clone Date: Fri, 17 Aug 2018 00:08:32 +0200 Message-ID: <20180816220832.GY4418@port70.net> References: <20180815174620.10752-1-segev208@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1534457204 3515 195.159.176.226 (16 Aug 2018 22:06:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2018 22:06:44 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) To: musl@lists.openwall.com Original-X-From: musl-return-13139-gllmg-musl=m.gmane.org@lists.openwall.com Fri Aug 17 00:06:40 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fqQPf-0000nQ-21 for gllmg-musl@m.gmane.org; Fri, 17 Aug 2018 00:06:39 +0200 Original-Received: (qmail 22082 invoked by uid 550); 16 Aug 2018 22:08:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 22059 invoked from network); 16 Aug 2018 22:08:44 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20180815174620.10752-1-segev208@gmail.com> Xref: news.gmane.org gmane.linux.lib.musl.general:13123 Archived-At: * Segev Finer [2018-08-15 20:46:17 +0300]: > This is the expected behavior of this function. Without this the child > task will crash on return from fn, since it will return to nowhere. > > I only tested MIPS O32. > sounds right to me, it affects users who call raw clone, the child function used in pthread_create in musl does not return so conforming posix code is not affected. > Segev Finer (3): > mips: Call exit on return from fn in __clone > mips64: Call exit on return from fn in __clone > mipsn32: Call exit on return from fn in __clone > > src/thread/mips/clone.s | 5 ++++- > src/thread/mips64/clone.s | 5 ++++- > src/thread/mipsn32/clone.s | 5 ++++- > 3 files changed, 12 insertions(+), 3 deletions(-) > > -- > 2.18.0