From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 0/3] mips{,64,n32}: Call exit on return from fn in __clone
Date: Thu, 16 Aug 2018 19:11:14 -0400 [thread overview]
Message-ID: <20180816231114.GK1878@brightrain.aerifal.cx> (raw)
In-Reply-To: <20180815174620.10752-1-segev208@gmail.com>
On Wed, Aug 15, 2018 at 08:46:17PM +0300, Segev Finer wrote:
> This is the expected behavior of this function. Without this the child
> task will crash on return from fn, since it will return to nowhere.
>
> I only tested MIPS O32.
>
> Segev Finer (3):
> mips: Call exit on return from fn in __clone
> mips64: Call exit on return from fn in __clone
> mipsn32: Call exit on return from fn in __clone
>
> src/thread/mips/clone.s | 5 ++++-
> src/thread/mips64/clone.s | 5 ++++-
> src/thread/mipsn32/clone.s | 5 ++++-
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
> --
> 2.18.0
These look fine, but I'm merging them into one commit. Thanks. Also
noting that the public interface fixed is clone() (vs __clone which is
internal).
Rich
prev parent reply other threads:[~2018-08-16 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 17:46 Segev Finer
2018-08-15 17:46 ` [PATCH 1/3] mips: " Segev Finer
2018-08-15 17:46 ` [PATCH 2/3] mips64: " Segev Finer
2018-08-15 17:46 ` [PATCH 3/3] mipsn32: " Segev Finer
2018-08-16 22:08 ` [PATCH 0/3] mips{,64,n32}: " Szabolcs Nagy
2018-08-16 23:11 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816231114.GK1878@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).