From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13139 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction Date: Fri, 24 Aug 2018 19:20:27 -0400 Message-ID: <20180824232027.GO1878@brightrain.aerifal.cx> References: <20180824193052.GD4418@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1535152724 11548 195.159.176.226 (24 Aug 2018 23:18:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Aug 2018 23:18:44 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-13157-gllmg-musl=m.gmane.org@lists.openwall.com Sat Aug 25 01:18:40 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ftLLc-0002dT-PT for gllmg-musl@m.gmane.org; Sat, 25 Aug 2018 01:18:32 +0200 Original-Received: (qmail 31950 invoked by uid 550); 24 Aug 2018 23:20:40 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 31932 invoked from network); 24 Aug 2018 23:20:39 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:13139 Archived-At: On Fri, Aug 24, 2018 at 02:58:04PM -0700, Andre McCurdy wrote: > On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy wrote: > > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t. > > That conditional was originally written under the assumption that musl > doesn't support thumb1 (so -mthumb -march=armv5t is not a supported > configuration). > > Was that assumption wrong? musl does not support being pure-thumb1 code, because some of the asm source files are not thumb-compatible, but I think the C code can be compiled as thumb1. -mthumb is only passed to the assembler for asm source files if __thumb2__ is defined. Rich