From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13262
Path: news.gmane.org!.POSTED!not-for-mail
From: Benjamin Peterson <benjamin@python.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH] improve error handling of ttyname_r and isatty
Date: Thu, 13 Sep 2018 14:23:41 -0700
Message-ID: <20180913212342.25800-1-benjamin@python.org>
References: <20180913182515.GK1878@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1536873724 9461 195.159.176.226 (13 Sep 2018 21:22:04 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Thu, 13 Sep 2018 21:22:04 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-13278-gllmg-musl=m.gmane.org@lists.openwall.com Thu Sep 13 23:22:00 2018
Return-path: <musl-return-13278-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.84_2)
	(envelope-from <musl-return-13278-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1g0Z3o-0002Jy-6C
	for gllmg-musl@m.gmane.org; Thu, 13 Sep 2018 23:22:00 +0200
Original-Received: (qmail 19679 invoked by uid 550); 13 Sep 2018 21:24:04 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 19604 invoked from network); 13 Sep 2018 21:24:03 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=python.org; s=200901;
	t=1536873832; bh=QP/O0ugIuC2yGdCVpyoCtbcj2u3ncqZTkAiHNOMhTpw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=aytxYl0EjLYnrag4LnA4hu/3dguBt74mnvINlnBIzDRl4WWDwvbh4wxYBdxsd/TTG
	 /zECyzlMEwbH1d2M9Mt5qP/YFUwpMI1dW5FfRSw85vIacaAfrfy2OUX82arlAxPp8A
	 BPWrU8rh7oVyvBxQqx+82gBFIK9PbIvmnk0cqcM0=
X-ME-Proxy: <xmx:ZtWaW9cv6uxzoafikwFrUYVmS0a4tZBA7qXcGrbVscEBF_1pgM-41g>
    <xmx:ZtWaWxVluHCp71RXIAGIszqJ5YGzyjtMRzFg77jhqd6UoEPfySs5pg>
    <xmx:ZtWaWzSX_fMxUBICQABtoTOpf8gWanRHTEjwhBlml8qsj17rPuRsCA>
    <xmx:ZtWaW82-TKQQJKsq_kc0evLhRhIJm6bEcEWhKVGqYXXIt_4u-sVMKw>
    <xmx:ZtWaW98gdNjo51WjGAl8dDCzy1k6mw8luCbXKM10Cks9jYGX4_3rQw>
    <xmx:ZtWaW7FJ-td5x0Q7y68RIcBTXN9jJnPlseyn10IhcYxHPyl_BEbbqw>
X-ME-Sender: <xms:ZtWaWxLfqTTWejgBmlGliDsdcD8Z49m7CzoROvWC6B5dsIMJDmDUIg>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20180913182515.GK1878@brightrain.aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:13262
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/13262>

I've made a new version with your comments addressed. I don't think we can
actually tail call through __syscall_ret in isatty(), since we need to return
nonzero if the syscall succeeded.