From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13327
Path: news.gmane.org!.POSTED!not-for-mail
From: Szabolcs Nagy <nsz@port70.net>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: riscv port for review
Date: Fri, 28 Sep 2018 12:33:54 +0200
Message-ID: <20180928103354.GK10209@port70.net>
References: <20180928022404.GQ17995@brightrain.aerifal.cx>
 <20180928024749.GS17995@brightrain.aerifal.cx>
 <A55607E4-90A5-4729-B44F-C89BAA8C41A5@mac.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: blaine.gmane.org 1538130723 7891 195.159.176.226 (28 Sep 2018 10:32:03 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 28 Sep 2018 10:32:03 +0000 (UTC)
User-Agent: Mutt/1.10.1 (2018-07-13)
Cc: palmer@sifive.com
To: musl@lists.openwall.com
Original-X-From: musl-return-13343-gllmg-musl=m.gmane.org@lists.openwall.com Fri Sep 28 12:31:58 2018
Return-path: <musl-return-13343-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.84_2)
	(envelope-from <musl-return-13343-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1g5q3y-0001ws-Iw
	for gllmg-musl@m.gmane.org; Fri, 28 Sep 2018 12:31:58 +0200
Original-Received: (qmail 20454 invoked by uid 550); 28 Sep 2018 10:34:07 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 20429 invoked from network); 28 Sep 2018 10:34:06 -0000
Mail-Followup-To: musl@lists.openwall.com, palmer@sifive.com
Content-Disposition: inline
In-Reply-To: <A55607E4-90A5-4729-B44F-C89BAA8C41A5@mac.com>
Xref: news.gmane.org gmane.linux.lib.musl.general:13327
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/13327>

* Michael Clark <michaeljclark@mac.com> [2018-09-28 18:33:18 +1200]:
> > On 28/09/2018, at 2:47 PM, Rich Felker <dalias@libc.org> wrote:
> > 
> >> On Thu, Sep 27, 2018 at 10:24:04PM -0400, Rich Felker wrote:
> >> Pulled from here:
> >> https://github.com/riscv/riscv-musl/commit/6a4f4a9c774608add4b02f95322518bd2f5f51ee
> >> 
> >> Attached for review.
> > 
> >> diff --git a/arch/riscv32/bits/alltypes.h.in b/arch/riscv32/bits/alltypes.h.in
> >> new file mode 100644
> >> index 0000000..66ca18a
> >> --- /dev/null
> >> +++ b/arch/riscv32/bits/alltypes.h.in
> >> @@ -0,0 +1,26 @@
> >> +#define _Addr int
> >> +#define _Int64 long long
> >> +#define _Reg int
> >> +
> >> +TYPEDEF __builtin_va_list va_list;
> >> +TYPEDEF __builtin_va_list __isoc_va_list;
> >> +
> >> +#ifndef __cplusplus
> >> +TYPEDEF int wchar_t;
> >> +#endif
> >> +
> >> +TYPEDEF float float_t;
> >> +TYPEDEF double double_t;
> >> +
> >> +TYPEDEF struct { long long __ll; long double __ld; } max_align_t;
> >> +
> >> +TYPEDEF long time_t;
> > 
> > Is riscv32 time_t really 32-bit? If so that's really disappointing,
> > but presumably unfixable...
> 
> This definitely is fixable as the riscv32 Linux ABI is not final.

i think linux is the problem: when x32 tried to do 64bit time_t
on an ilp32 target it turned out to be a disaster, because
various driver and fs code can only deal with 32bit time_t when
long is 32bit (although x32 had other issues too: mixing 64bit
kernel space and 32bit userspace types).

the consensus after x32 was that new 32bit targets will keep
using 32bit time_t and there is an independent project to add
64bit time_t support (by introducing new syscalls, types etc)
that will apply to all 32bit targets once it's done.