From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13343 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] fix tlsdesc asm on arm with hard float abi Date: Sun, 7 Oct 2018 21:09:07 +0200 Message-ID: <20181007190907.GP10209@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="7LkOrbQMr4cezO2T" X-Trace: blaine.gmane.org 1538939238 22474 195.159.176.226 (7 Oct 2018 19:07:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Oct 2018 19:07:18 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-13359-gllmg-musl=m.gmane.org@lists.openwall.com Sun Oct 07 21:07:14 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1g9EOY-0005li-3N for gllmg-musl@m.gmane.org; Sun, 07 Oct 2018 21:07:14 +0200 Original-Received: (qmail 32451 invoked by uid 550); 7 Oct 2018 19:09:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32400 invoked from network); 7 Oct 2018 19:09:19 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline Xref: news.gmane.org gmane.linux.lib.musl.general:13343 Archived-At: --7LkOrbQMr4cezO2T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline for me this fixes src/ldso/arm/tlsdesc.S: Assembler messages: src/ldso/arm/tlsdesc.S:54: Error: selected processor does not support `vpush {d0-d7}' in ARM mode src/ldso/arm/tlsdesc.S:61: Error: selected processor does not support `vpop {d0-d7}' in ARM mode --7LkOrbQMr4cezO2T Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-fix-tlsdesc-asm-on-arm-with-hard-float-abi.patch" >From 5a7ee1904c33f97bcb47ec6d729f399ae8036b4d Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Sun, 7 Oct 2018 18:31:43 +0000 Subject: [PATCH] fix tlsdesc asm on arm with hard float abi gcc does not always pass flags to the assembler to indicate the fpu settings, instead it just adds .fpu directives to the generated asm, so in handwritten asm we have to do the same (the same approach is used in setjmp.s already). --- src/ldso/arm/tlsdesc.S | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ldso/arm/tlsdesc.S b/src/ldso/arm/tlsdesc.S index b81f3111..b8c54aae 100644 --- a/src/ldso/arm/tlsdesc.S +++ b/src/ldso/arm/tlsdesc.S @@ -51,14 +51,18 @@ __tlsdesc_dynamic: 3: #if __ARM_PCS_VFP || !__SOFTFP__ + .fpu vfp vpush {d0-d7} + .fpu softvfp #endif push {r0-r3} add r0,sp,#4 bl __tls_get_new pop {r1-r3,ip} #if __ARM_PCS_VFP || !__SOFTFP__ + .fpu vfp vpop {d0-d7} + .fpu softvfp #endif sub r0,r0,r1 // r0 = retval-tp b 4b -- 2.18.0 --7LkOrbQMr4cezO2T--