From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13359
Path: news.gmane.org!.POSTED!not-for-mail
From: Rich Felker <dalias@libc.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: riscv port for review
Date: Thu, 11 Oct 2018 11:49:27 -0400
Message-ID: <20181011154927.GB5150@brightrain.aerifal.cx>
References: <20180928022404.GQ17995@brightrain.aerifal.cx>
 <CAGw6cBs7XPxue4w7jm5P3124Z-odh434WaJr1FZBKK-6kE=NwQ@mail.gmail.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: blaine.gmane.org 1539272856 3240 195.159.176.226 (11 Oct 2018 15:47:36 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Thu, 11 Oct 2018 15:47:36 +0000 (UTC)
User-Agent: Mutt/1.5.21 (2010-09-15)
To: musl@lists.openwall.com
Original-X-From: musl-return-13375-gllmg-musl=m.gmane.org@lists.openwall.com Thu Oct 11 17:47:32 2018
Return-path: <musl-return-13375-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.84_2)
	(envelope-from <musl-return-13375-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1gAdBU-0000lP-6Q
	for gllmg-musl@m.gmane.org; Thu, 11 Oct 2018 17:47:32 +0200
Original-Received: (qmail 1740 invoked by uid 550); 11 Oct 2018 15:49:40 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 1721 invoked from network); 11 Oct 2018 15:49:40 -0000
Content-Disposition: inline
In-Reply-To: <CAGw6cBs7XPxue4w7jm5P3124Z-odh434WaJr1FZBKK-6kE=NwQ@mail.gmail.com>
Original-Sender: Rich Felker <dalias@aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:13359
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/13359>

On Thu, Oct 11, 2018 at 12:34:40AM -0700, Michael Forney wrote:
> On 2018-09-27, Rich Felker <dalias@libc.org> wrote:
> > Pulled from here:
> > https://github.com/riscv/riscv-musl/commit/6a4f4a9c774608add4b02f95322518bd2f5f51ee
> >
> > Attached for review.
> 
> I noticed that some fcntl.h constants are incorrect (O_DIRECTORY,
> O_NOFOLLOW, O_DIRECT, O_LARGEFILE, and O_TMPFILE). Linux doesn't seem
> to have a riscv-specific fcntl.h, so I think they just come from
> asm-generic.

If that's the case the riscv32/riscv64 bits/fcntl.h files should just
be removed and the generic one will be used.

Rich