From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13422 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix many compiler warnings Date: Sat, 10 Nov 2018 18:23:26 +0100 Message-ID: <20181110172325.GD21289@port70.net> References: <1636016.5PCnkOXM1K@prometheus.sedrubal.de> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1541870495 2966 195.159.176.226 (10 Nov 2018 17:21:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 17:21:35 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-13438-gllmg-musl=m.gmane.org@lists.openwall.com Sat Nov 10 18:21:31 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1gLWwr-0000cl-II for gllmg-musl@m.gmane.org; Sat, 10 Nov 2018 18:21:29 +0100 Original-Received: (qmail 31929 invoked by uid 550); 10 Nov 2018 17:23:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 31908 invoked from network); 10 Nov 2018 17:23:38 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <1636016.5PCnkOXM1K@prometheus.sedrubal.de> Xref: news.gmane.org gmane.linux.lib.musl.general:13422 Archived-At: * Sedrubal [2018-11-10 17:48:23 +0100]: > I'm building musl for aarch64 with clang and get many compiler warnings > (mostly Wbitwise-op-parentheses, Wshift-op-parentheses and Wlogical-op-parentheses). > I tried to fix them (and I hope, I did not introduce new bugs). suppress the warnings, you will just introduce bugs > - return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24; > + return __x>>24 | __x>>(8&0xff00) | __x<<(8&0xff0000) | __x<<24; e.g. this is wrong