From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13439 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH] Fix many compiler warnings Date: Tue, 13 Nov 2018 11:55:30 +0100 Message-ID: <20181113105530.GE21289@port70.net> References: <1636016.5PCnkOXM1K@prometheus.sedrubal.de> <1676444.u5bekTFY47@prometheus.sedrubal.de> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1542106430 25439 195.159.176.226 (13 Nov 2018 10:53:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2018 10:53:50 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Sedrubal To: musl@lists.openwall.com Original-X-From: musl-return-13455-gllmg-musl=m.gmane.org@lists.openwall.com Tue Nov 13 11:53:46 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1gMWKB-0006I4-LO for gllmg-musl@m.gmane.org; Tue, 13 Nov 2018 11:53:39 +0100 Original-Received: (qmail 8177 invoked by uid 550); 13 Nov 2018 10:55:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 8159 invoked from network); 13 Nov 2018 10:55:42 -0000 Mail-Followup-To: musl@lists.openwall.com, Sedrubal Content-Disposition: inline In-Reply-To: <1676444.u5bekTFY47@prometheus.sedrubal.de> Xref: news.gmane.org gmane.linux.lib.musl.general:13439 Archived-At: * Sedrubal [2018-11-13 01:15:11 +0100]: > > Well, hope belongs in the church. Whether or not you introduced bugs is > > a thing you can test for. There is libc-test. > > You're right, I'm sorry. Unfortunately for me libc-test contains 5 errors for > master, v1.1.20 and for master+my changes. So I'm not sure, if I broke > something... > you don't need to run libc-test. you have to ensure that before and after the patch the exact same stripped libc binaries are generated and point this out in the commit message. (in principle register allocation, instruction scheduling etc can change, in practice that should not happen if you get all parenthesis right and use the same toolchain. not all header files are used in libc code so you could write further tests for them or compile code using them if you want to make sure everything works, but that's not critical.)