mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: Re: [PATCH libc-test] add strptime basic test
Date: Fri, 16 Nov 2018 16:36:06 -0500	[thread overview]
Message-ID: <20181116213606.GL5150@brightrain.aerifal.cx> (raw)
In-Reply-To: <20181115212658.GI21289@port70.net>

On Thu, Nov 15, 2018 at 10:26:58PM +0100, Szabolcs Nagy wrote:
> * Rafał Miłecki <zajec5@gmail.com> [2018-11-15 11:12:34 +0100]:
> > It also fails with:
> > 
> > "%F": failed to parse "1856-07-10"
> > "%s": failed to parse "683078400"
> > "%z": failed to parse "+0200"
> > "%z": failed to parse "-0530"
> > "%z": failed to parse "-06"
> > 
> > but that's expected due to unimplemented %F %s and %z.
> 
> v2 looks good, but these are testing extensions.
> 
> do you intend to add patch for %F and %s too?
> if not i'll disable those tests

I think it's a good idea to keep tests for standards-mandated behavior
separate from tests for extensions, even if we do want to support the
latter in musl, and name them appropriately. It matters if/when people
use libc-test to assess the conformance of another implementation that
may not have made the same choices about extensions.

Rich


  parent reply	other threads:[~2018-11-16 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  7:34 Rafał Miłecki
2018-11-15 10:12 ` Rafał Miłecki
2018-11-15 21:26   ` Szabolcs Nagy
2018-11-15 21:31     ` Rafał Miłecki
2018-11-16 21:36     ` Rich Felker [this message]
2018-11-16 21:21   ` Bartosz Brachaczek
2018-11-16 21:34     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116213606.GL5150@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --cc=rafal@milecki.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).