From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13456 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH libc-test] add strptime basic test Date: Fri, 16 Nov 2018 16:36:06 -0500 Message-ID: <20181116213606.GL5150@brightrain.aerifal.cx> References: <20181115073456.11105-1-zajec5@gmail.com> <20181115212658.GI21289@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1542404054 5088 195.159.176.226 (16 Nov 2018 21:34:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2018 21:34:14 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Original-X-From: musl-return-13472-gllmg-musl=m.gmane.org@lists.openwall.com Fri Nov 16 22:34:10 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1gNlkg-0001EN-FX for gllmg-musl@m.gmane.org; Fri, 16 Nov 2018 22:34:10 +0100 Original-Received: (qmail 10215 invoked by uid 550); 16 Nov 2018 21:36:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 10192 invoked from network); 16 Nov 2018 21:36:18 -0000 Content-Disposition: inline In-Reply-To: <20181115212658.GI21289@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:13456 Archived-At: On Thu, Nov 15, 2018 at 10:26:58PM +0100, Szabolcs Nagy wrote: > * Rafał Miłecki [2018-11-15 11:12:34 +0100]: > > It also fails with: > > > > "%F": failed to parse "1856-07-10" > > "%s": failed to parse "683078400" > > "%z": failed to parse "+0200" > > "%z": failed to parse "-0530" > > "%z": failed to parse "-06" > > > > but that's expected due to unimplemented %F %s and %z. > > v2 looks good, but these are testing extensions. > > do you intend to add patch for %F and %s too? > if not i'll disable those tests I think it's a good idea to keep tests for standards-mandated behavior separate from tests for extensions, even if we do want to support the latter in musl, and name them appropriately. It matters if/when people use libc-test to assess the conformance of another implementation that may not have made the same choices about extensions. Rich