From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: sem_wait and EINTR
Date: Wed, 5 Dec 2018 22:17:56 -0500 [thread overview]
Message-ID: <20181206031756.GZ23599@brightrain.aerifal.cx> (raw)
In-Reply-To: <20181206024340.202e0fc4@orivej.orivej.org>
On Thu, Dec 06, 2018 at 02:43:40AM +0000, Orivej Desh wrote:
> * Rich Felker <dalias@libc.org> [2018-12-05]
> > On Wed, Dec 05, 2018 at 10:27:16PM +0100, Ondřej Jirman wrote:
> > > On Wed, Dec 05, 2018 at 08:47:59PM +0100, Markus Wichmann wrote:
> > >
> > > It's specified by POSIX:
> > >
> > > https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_wait.html
> > >
> > > Sates: "The sem_wait() function is interruptible by the delivery of a signal."
> >
> > This seems contradictory with EINTR being a "may fail" error, and, if
> > interpreted the way you want to interpret it, seems to be
> > contradictory with SA_RESTART semantics, since it doesn't say anything
> > about whether that signal is an interrupting one. I think we should
> > attempt to obtain a clarification on what the intent is here. Does "is
> > interruptible" mean that it needs to fail on signals (only without
> > SA_RESTART?) or simply that signal handlers must be permitted to run
> > (i.e. the wait can't happen with signals blocked)?
>
> There is a definition of interruptible functions on the sigaction page:
>
> SA_RESTART
>
> This flag affects the behavior of interruptible functions; that is, those
> specified to fail with errno set to [EINTR].
>
> If set, and a function specified as interruptible is interrupted by this
> signal, the function shall restart and shall not fail with [EINTR] unless
> otherwise specified.
>
> If the flag is not set, interruptible functions interrupted by this signal
> shall fail with errno set to [EINTR].
>
> https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigaction.html
OK, this seems correct. I still don't understand why EINTR is a "may
fail" error; it's been that way at least back to SUSv2:
http://pubs.opengroup.org/onlinepubs/7908799/xsh/sem_wait.html
I'd like it if we could avoid the pre-linux-2.6.22 bug of spurious
EINTR from SYS_futex, but I don't see any way to do so except possibly
wrapping all signal handlers and implementing restart-vs-EINTR
ourselves. So if we need to change this, it might just be a case where
we say "well, sorry, your kernel is broken" if someone is using a
broken kernel.
Thoughts?
Rich
next prev parent reply other threads:[~2018-12-06 3:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:16 Orivej Desh
2018-12-05 19:47 ` Markus Wichmann
2018-12-05 21:27 ` Ondřej Jirman
2018-12-05 21:58 ` Rich Felker
2018-12-06 2:43 ` Orivej Desh
2018-12-06 3:17 ` Rich Felker [this message]
2018-12-06 15:57 ` Markus Wichmann
2018-12-06 16:23 ` Rich Felker
2018-12-06 17:03 ` Markus Wichmann
2018-12-06 17:33 ` Markus Wichmann
2018-12-06 20:31 ` Orivej Desh
2018-12-09 2:51 ` Rich Felker
2018-12-09 6:50 ` Markus Wichmann
2018-12-12 0:32 ` Rich Felker
2018-12-12 5:15 ` Markus Wichmann
2018-12-14 19:45 ` Rich Felker
2018-12-15 9:45 ` Markus Wichmann
2018-12-05 22:03 ` Rich Felker
2018-12-06 2:43 ` Orivej Desh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206031756.GZ23599@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).