mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Michael Kaufmann <mail@michael-kaufmann.ch>
To: musl@lists.openwall.com
Subject: Re: Use local time in syslog() function
Date: Mon, 14 Jan 2019 20:53:45 +0100	[thread overview]
Message-ID: <20190114205345.Horde.IcnVhJs0RGJWUQBLwJoyrNv@webmail.michael-kaufmann.ch> (raw)
In-Reply-To: <20190114162534.GD23599@brightrain.aerifal.cx>

>> I have found a bug in the implementation of syslog(). It should use
>> the local time instead of UTC when sending the message to /dev/log.
>> So in src/misc/syslog.c, the call to gmtime_r() should be replaced
>> with localtime_r().
>
> This is not a bug; rather, use of local time there in glibc and other
> systems is a bug. Local time varies by the sending process and
> produces inconsistent and uninterpretable log messages. Moreover the
> syslog() function is not specified to depend on the environment and
> thereby is not allowed to call any function whose behavior is
> dependant on the environment.

Thank you for responding!

I agree that GMT would have been a better choice, but I think local  
time is also mandated by RFC 3164,  
https://tools.ietf.org/html/rfc3164#section-4.1.2 : "The TIMESTAMP  
field is the local time". Or does this RFC not apply for syslog() on  
Linux?

There's also this older discussion:  
https://www.openwall.com/lists/musl/2014/01/28/2 - sorry, I have not  
found it before.

Regards,
Michael



  reply	other threads:[~2019-01-14 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  9:23 Michael Kaufmann
2019-01-14 16:25 ` Rich Felker
2019-01-14 19:53   ` Michael Kaufmann [this message]
2019-01-14 20:27     ` Rich Felker
2019-01-14 23:02       ` Szabolcs Nagy
2019-01-15  4:12         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114205345.Horde.IcnVhJs0RGJWUQBLwJoyrNv@webmail.michael-kaufmann.ch \
    --to=mail@michael-kaufmann.ch \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).