From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13596 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Kaufmann Newsgroups: gmane.linux.lib.musl.general Subject: Re: Use local time in syslog() function Date: Mon, 14 Jan 2019 20:53:45 +0100 Message-ID: <20190114205345.Horde.IcnVhJs0RGJWUQBLwJoyrNv@webmail.michael-kaufmann.ch> References: <20190114102303.Horde.cORQXioih5pWeAh2Yr2gztG@webmail.michael-kaufmann.ch> <20190114162534.GD23599@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes X-Trace: blaine.gmane.org 1547495512 14361 195.159.176.226 (14 Jan 2019 19:51:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2019 19:51:52 +0000 (UTC) User-Agent: Horde Application Framework 5 To: musl@lists.openwall.com Original-X-From: musl-return-13612-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jan 14 20:51:48 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1gj8Gy-0003cH-9w for gllmg-musl@m.gmane.org; Mon, 14 Jan 2019 20:51:48 +0100 Original-Received: (qmail 24523 invoked by uid 550); 14 Jan 2019 19:53:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24496 invoked from network); 14 Jan 2019 19:53:57 -0000 Authentication-Results: lookie.metanet.ch; spf=pass (sender IP is 127.0.0.1) smtp.mailfrom=mail@michael-kaufmann.ch smtp.helo=lookie.metanet.ch Received-SPF: pass (lookie.metanet.ch: connection is authenticated) In-Reply-To: <20190114162534.GD23599@brightrain.aerifal.cx> Content-Disposition: inline Xref: news.gmane.org gmane.linux.lib.musl.general:13596 Archived-At: >> I have found a bug in the implementation of syslog(). It should use >> the local time instead of UTC when sending the message to /dev/log. >> So in src/misc/syslog.c, the call to gmtime_r() should be replaced >> with localtime_r(). > > This is not a bug; rather, use of local time there in glibc and other > systems is a bug. Local time varies by the sending process and > produces inconsistent and uninterpretable log messages. Moreover the > syslog() function is not specified to depend on the environment and > thereby is not allowed to call any function whose behavior is > dependant on the environment. Thank you for responding! I agree that GMT would have been a better choice, but I think local time is also mandated by RFC 3164, https://tools.ietf.org/html/rfc3164#section-4.1.2 : "The TIMESTAMP field is the local time". Or does this RFC not apply for syslog() on Linux? There's also this older discussion: https://www.openwall.com/lists/musl/2014/01/28/2 - sorry, I have not found it before. Regards, Michael