From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13757 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc Date: Mon, 11 Feb 2019 18:30:36 -0500 Message-ID: <20190211233036.GG23599@brightrain.aerifal.cx> References: <20181106063655.12357-1-mforney@mforney.org> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73735"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-13773-gllmg-musl=m.gmane.org@lists.openwall.com Tue Feb 12 00:30:57 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1gtL2P-000J2Y-60 for gllmg-musl@m.gmane.org; Tue, 12 Feb 2019 00:30:57 +0100 Original-Received: (qmail 14311 invoked by uid 550); 11 Feb 2019 23:30:49 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14251 invoked from network); 11 Feb 2019 23:30:48 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:13757 Archived-At: On Sun, Feb 10, 2019 at 11:27:21AM -0800, Michael Forney wrote: > On 2018-11-05, Michael Forney wrote: > > When the gcc and binutils build trees were separated in defdbb4505, > > --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG. > > This had the effect of reverting commit e83fe4b8ce, breaking > > reproducible builds (unless it was specified explicitly in config.mak). > > --- > > litecross/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/litecross/Makefile b/litecross/Makefile > > index 2f78157..4ecfa93 100644 > > --- a/litecross/Makefile > > +++ b/litecross/Makefile > > @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \ > > --disable-werror \ > > --target=$(TARGET) --prefix= \ > > --libdir=/lib --disable-multilib \ > > - --with-sysroot=$(SYSROOT) > > + --with-sysroot=$(SYSROOT) \ > > + --enable-deterministic-archives > > > > FULL_GCC_CONFIG = --enable-languages=c,c++ \ > > $(GCC_CONFIG_FOR_TARGET) \ > > @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \ > > --disable-libmudflap --disable-libsanitizer \ > > --disable-gnu-indirect-function \ > > --disable-libmpx \ > > - --enable-deterministic-archives \ > > --enable-libstdcxx-time > > > > FULL_MUSL_CONFIG = $(MUSL_CONFIG) \ > > -- > > 2.19.1 > > Ping. I think this patch should be pretty uncontroversial. It is a > simple fix for a regression introduced in defdbb4505. > > Would you prefer a github pull request instead? Sorry, it was just an oversight. Applying. Thanks! Rich