From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: fgets() doesn't call fsync() before getting input
Date: Thu, 21 Feb 2019 12:07:48 -0500 [thread overview]
Message-ID: <20190221170748.GI23599@brightrain.aerifal.cx> (raw)
In-Reply-To: <5c1de98e-9606-81d6-0e69-8f3dbb916065@adelielinux.org>
On Thu, Feb 21, 2019 at 10:31:36AM -0600, A. Wilcox wrote:
> On 02/21/19 09:22, Rich Felker wrote:
> > On Thu, Feb 21, 2019 at 10:09:03AM -0500, James Larrowe wrote:
> >> I'm writing a program that prints a dialogue to the screen and then asks
> >> for input. In musl, the dialogue does not show before fgets() is called,
> >> however in glibc it does. That causes a blank prompt and also some
> >> confusion. Attached is a minimal example and a log.
> >
> > This difference is intentional. The specification allows but does not
> > require that attempting to read from a line-buffered input stream
> > causes all line-buffered output streams to be flushed. This behavior
> > was somewhat convenient for old-style input-prompt idioms, but it
> > doesn't scale with large numbers of files open and deadlocks with some
> > multi-threaded usage. The portable solution here for applications is
> > to fflush (not fsync) the particular stream you want flushed.
> >
> > Rich
>
>
> FWIW, the only package we've come across where this is a problem is
> mac-fdisk (which hasn't been updated since 1997 - yes, 22 years ago).
>
> We have a patch:
>
> https://code.foxkit.us/adelie/packages/blob/master/user/mac-fdisk/flush-stdout.patch
I think it's more of an issue for the early examples in C books and
tutorials, which invariably but inexplicably use a 1970s-era "prompt
for input" model rather than argv[] or something that would be a lot
more familiar (and amenable to testing) to modern readers.
Rich
next prev parent reply other threads:[~2019-02-21 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:09 James Larrowe
2019-02-21 15:22 ` Rich Felker
2019-02-21 16:31 ` A. Wilcox
2019-02-21 17:07 ` Rich Felker [this message]
2019-02-21 19:24 ` Laurent Bercot
2019-02-21 20:16 ` James Larrowe
2019-02-21 20:44 ` Rich Felker
2019-02-22 5:04 ` Markus Wichmann
2019-02-25 13:10 ` James Larrowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221170748.GI23599@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).