mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Sebastian Kemper <sebastian_ml@gmx.net>
To: musl@lists.openwall.com
Subject: Re: Asterisk 16 segmentation fault
Date: Sat, 2 Mar 2019 18:16:42 +0100	[thread overview]
Message-ID: <20190302171641.GA1760@darth.lan> (raw)
In-Reply-To: <20190228211901.GJ21289@port70.net>

On Thu, Feb 28, 2019 at 10:19:02PM +0100, Szabolcs Nagy wrote:
> e.g. the segfault can be avoided by
> 
> -			const char *dlerror_msg = ast_strdupa(dlerror());
> +			const char *dlerror_msg = dlerror(); dlerror_msg = ast_strdupa(dlerror_msg ? dlerror_msg : "");
> 
> but we would need to know what this code is trying to do
> (and how it worked before) for a proper fix.

Hello Szabolcs,

This seems to work. I was able to compile and run asterisk with this
(and make some phone calls).

I will raise a bug report upstream for this and point them here. I'm not
going to raise a pull request with your patch as upstream's handling of
pull requests includes signing some agreement etc.

I'll just point them to this thread and see what comes out of it.

Thanks again!

Kind regards,
Seb


  parent reply	other threads:[~2019-03-02 17:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 20:27 Sebastian Kemper
2019-02-28 21:15 ` Rich Felker
2019-02-28 21:32   ` Jeffrey Walton
2019-02-28 21:19 ` Szabolcs Nagy
2019-02-28 22:01   ` Sebastian Kemper
2019-03-02 17:16   ` Sebastian Kemper [this message]
2019-03-02 17:36     ` Rich Felker
2019-03-02 17:59       ` Sebastian Kemper
2019-05-27 20:14         ` Sebastian Kemper
2019-05-28 20:21           ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190302171641.GA1760@darth.lan \
    --to=sebastian_ml@gmx.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).