mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Cc: Michael Jeanson <mjeanson@efficios.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
Subject: Re: sysconf(_SC_NPROCESSORS_CONF) returns the wrong value
Date: Sat, 16 Mar 2019 03:25:34 +0100	[thread overview]
Message-ID: <20190316022534.GN26605@port70.net> (raw)
In-Reply-To: <20190315210202.GD6994@joraj-alpa>

* Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com> [2019-03-15 17:02:02 -0400]:
> We are currently in the process of making sure that lttng [1] (linux tracer) run
> smoothly on system using musl (Yocto, Alpine etc.). Most things work
> fine. Still, we currently have tests that are failing due to an issue regarding
> the reported number of configured processors on the system (__SC_NPROCESSORS_CONF).
> Note that users of LTTng are also affected by this if they chose to modify the
> sched affinity of their instrumented apps. This is relatively a big deal for us.
> 
> Long story short, we start an app with "taskset -c 0" and we need to allocate
> data structure internally but using the number of configured processors not the
> number of online processors. To do so we call sysconf(__SC_NPROCESSORS_CONF).
> Slight problem: the value returned is the _SC_NPROCESSORS_ONLN value instead of
> __SC_NPROCESSORS_CONF.
...
> A simple command line to show this:
> 
>   taskset -c 0 nproc --all
> 
> This is equivalent to asking sysconf(__SC_NPROCESSORS_CONF).

the right way to check the sysconf from a shell is getconf

on glibc system
$ taskset -c 0 getconf -a |grep NPROC
_NPROCESSORS_CONF                  8
_NPROCESSORS_ONLN                  8

on musl
$ taskset -c 0 getconf -a |grep NPROC
_NPROCESSORS_CONF                  1
_NPROCESSORS_ONLN                  1

so both values differ (plain nproc returns the affinity number,
*_ONLN is all the cpus that the kernel schedules to, *_CONF
includes offline cpus that may be hotplugged)

these are documented linux extensions so i think musl should follow
the linux sysconf man page. (but the semantics is not entirely clear
e.g. there is /sys/devices/system/cpu/possible which can have larger
number than echo /sys/devices/system/cpu/cpu[0-9]* |wc -w which is
what glibc seems to be doing for *_CONF)

i think we need to know why does a process care if musl returns
the wrong number? or what are the valid uses of such a number?
(there are heterogeous systems like arm big-little, numa systems
with many sockets, containers, virtualization,.. how deep may a
user process need to go down in this rabbit hole?)

note that most of /sys/devices/system/cpu/* is documented under
Documentation/ABI/testing in linux, not in Documentation/ABI/stable
and the format is not detailed, and some apis (e.g. /proc/cpuinfo)
are known to be different on android (and grsec?) kernels it may
be unmounted during early boot or in chroots, so sysfs parsing is
only done when really necessary.


  reply	other threads:[~2019-03-16  2:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 21:02 Jonathan Rajotte-Julien
2019-03-16  2:25 ` Szabolcs Nagy [this message]
2019-03-16 13:58   ` Mathieu Desnoyers
2019-03-16 14:28   ` Jonathan Rajotte-Julien
2019-03-19 19:11   ` Florian Weimer
2019-03-26 16:23   ` Jonathan Rajotte-Julien
2019-03-26 17:45     ` Szabolcs Nagy
2019-03-26 18:01       ` Mathieu Desnoyers
2019-04-02 19:02         ` Szabolcs Nagy
2019-04-02 22:38           ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190316022534.GN26605@port70.net \
    --to=nsz@port70.net \
    --cc=jonathan.rajotte-julien@efficios.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mjeanson@efficios.com \
    --cc=musl@lists.openwall.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).