From: <vilimp@volny.cz>
To: <musl@lists.openwall.com>
Cc: "vilimp" <vilimp@volny.cz>
Subject: clarify bswap a bit more for gcc
Date: Sun, 24 Mar 2019 12:26:18 +0100 [thread overview]
Message-ID: <20190324122618.D367D3A0@volny.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
Hi,
i recently found musl and i started to play with it, i.e. comparing result
of compilation against glibc.
i know nearly nothing about programing, but is it possible to upstream this
patch, please? It gets rid of gcc's warnings.
> If you are not subscribed and want to be Cc’d on replies, please
> mention that in your post.
Yes, please.
Best regards,
PV
[-- Attachment #2: bswap.patch --]
[-- Type: application/octet-stream, Size: 1147 bytes --]
diff --git a/byteswap.h_orig b/byteswap.h
index 00b9df3..928be2b 100644
--- a/byteswap.h_orig
+++ b/byteswap.h
@@ -11,12 +11,12 @@ static __inline uint16_t __bswap_16(uint16_t __x)
static __inline uint32_t __bswap_32(uint32_t __x)
{
- return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
+ return __x>>24 | (__x>>8&0xff00) | (__x<<8&0xff0000) | __x<<24;
}
static __inline uint64_t __bswap_64(uint64_t __x)
{
- return __bswap_32(__x)+0ULL<<32 | __bswap_32(__x>>32);
+ return (__bswap_32(__x)+0ULL)<<32 | __bswap_32(__x>>32);
}
#define bswap_16(x) __bswap_16(x)
diff --git a/endian.h_orig b/endian.h
index 1bd4445..88c3347 100644
--- a/endian.h_orig
+++ b/endian.h
@@ -29,12 +29,12 @@ static __inline uint16_t __bswap16(uint16_t __x)
static __inline uint32_t __bswap32(uint32_t __x)
{
- return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
+ return __x>>24 | (__x>>8&0xff00) | (__x<<8&0xff0000) | __x<<24;
}
static __inline uint64_t __bswap64(uint64_t __x)
{
- return __bswap32(__x)+0ULL<<32 | __bswap32(__x>>32);
+ return (__bswap32(__x)+0ULL)<<32 | __bswap32(__x>>32);
}
#if __BYTE_ORDER == __LITTLE_ENDIAN
next reply other threads:[~2019-03-24 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 11:26 vilimp [this message]
2019-03-24 14:31 ` Pascal Cuoq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324122618.D367D3A0@volny.cz \
--to=vilimp@volny.cz \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).