From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14055 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix unintended global symbols in atanl.c Date: Wed, 3 Apr 2019 10:16:27 -0400 Message-ID: <20190403141627.GP23599@brightrain.aerifal.cx> References: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="79777"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14071-gllmg-musl=m.gmane.org@lists.openwall.com Wed Apr 03 16:16:44 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hBgh0-000KaJ-VR for gllmg-musl@m.gmane.org; Wed, 03 Apr 2019 16:16:43 +0200 Original-Received: (qmail 7478 invoked by uid 550); 3 Apr 2019 14:16:40 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7460 invoked from network); 3 Apr 2019 14:16:39 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14055 Archived-At: On Wed, Apr 03, 2019 at 05:56:08AM -0700, Dan Gohman wrote: > Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended > to be part of the public API. > > These are already static in the LDBL_MANT_DIG == 64 code, so this patch is > just making the LDBL_MANT_DIG == 113 code do the same thing. > --- > src/math/atanl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/math/atanl.c b/src/math/atanl.c > index 79a3edb8..c3b0c926 100644 > --- a/src/math/atanl.c > +++ b/src/math/atanl.c > @@ -70,21 +70,21 @@ static long double T_odd(long double x) > #elif LDBL_MANT_DIG == 113 > #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) > > -const long double atanhi[] = { > +static const long double atanhi[] = { > 4.63647609000806116214256231461214397e-01L, > 7.85398163397448309615660845819875699e-01L, > 9.82793723247329067985710611014666038e-01L, > 1.57079632679489661923132169163975140e+00L, > }; > > -const long double atanlo[] = { > +static const long double atanlo[] = { > 4.89509642257333492668618435220297706e-36L, > 2.16795253253094525619926100651083806e-35L, > -2.31288434538183565909319952098066272e-35L, > 4.33590506506189051239852201302167613e-35L, > }; > > -const long double aT[] = { > +static const long double aT[] = { > 3.33333333333333333333333333333333125e-01L, > -1.99999999999999999999999999999180430e-01L, > 1.42857142857142857142857142125269827e-01L, > -- > 2.17.1 Your email system appears to have corrupted the patch; it does not apply. Can you please resend as an attachment in the same git format-patch form? Rich