From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14116 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove unused variables from dynlink.c Date: Sun, 12 May 2019 09:51:07 -0400 Message-ID: <20190512135107.GM23599@brightrain.aerifal.cx> References: <20190512015050.wjm37cco537skyf5@gmail.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125221"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14132-gllmg-musl=m.gmane.org@lists.openwall.com Sun May 12 15:51:25 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hPosu-000WSj-VU for gllmg-musl@m.gmane.org; Sun, 12 May 2019 15:51:25 +0200 Original-Received: (qmail 23805 invoked by uid 550); 12 May 2019 13:51:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23787 invoked from network); 12 May 2019 13:51:20 -0000 Content-Disposition: inline In-Reply-To: <20190512015050.wjm37cco537skyf5@gmail.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14116 Archived-At: On Sun, May 12, 2019 at 09:50:50AM +0800, Fangrui Song wrote: > > --- > ldso/dynlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ldso/dynlink.c b/ldso/dynlink.c > index 42a5470d..ad0cdba2 100644 > --- a/ldso/dynlink.c > +++ b/ldso/dynlink.c > @@ -86,7 +86,6 @@ struct dso { > size_t relro_start, relro_end; > uintptr_t *new_dtv; > unsigned char *new_tls; > - volatile int new_dtv_idx, new_tls_idx; > struct td_index *td_index; > struct dso *fini_next; > char *shortname; > -- > 2.21.0 Looks ok. Your mail client seems to have corrupted the patch though; git am is rejecting it for some reason. I'll apply it manually. In the future if you can't get your mail client to send patches inline without breaking the formatting, attachments are fine/preferred. Rich