From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14118 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Fangrui Song Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove unused variables from dynlink.c Date: Sun, 12 May 2019 22:24:08 +0800 Message-ID: <20190512142408.2to3ealai3cbtbf5@gmail.com> References: <20190512015050.wjm37cco537skyf5@gmail.com> <20190512135107.GM23599@brightrain.aerifal.cx> <20190512135418.GN23599@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5946"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180223-112-0c5bf3 Cc: musl@lists.openwall.com To: Rich Felker Original-X-From: musl-return-14134-gllmg-musl=m.gmane.org@lists.openwall.com Sun May 12 16:24:28 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hPpOt-0001OX-Jp for gllmg-musl@m.gmane.org; Sun, 12 May 2019 16:24:27 +0200 Original-Received: (qmail 15943 invoked by uid 550); 12 May 2019 14:24:24 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 15919 invoked from network); 12 May 2019 14:24:24 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OL0VfosBAHmm0e4HnWvdNdfQpV3rpt5oOW4ScUJHD84=; b=BfVOoR9q3hxiN8Ofbz44Wv3nyf+Y4ajRy8c8SeuKwbprMgrQTNzYcmDS3wSBCN5S9r /xWRLJsmrLyM/Gjd9j3txVWQFeEydVFkjsgfNFXfwOTl+IPuVzwG1QiBtV7G56i2PkqA 4hNdMaxYOO4AH0nWZhwgT9Smk93CQVdOx9XkRDstNSSRmHOqA7bNtTJcQfLXpgRvEGc1 DVtdSp745Mnv3D4+SW/e1aCQbH3AQzjzal76VWN1dizc43je+0uX54Y8VoDXhHaNbq/H F6HBt+p0cIaGkoyWEU9vJ5odR695D4vrqnRGqTxN8xJ1bR5HqcxZBNl4o5wWbBo2T32J pecw== X-Gm-Message-State: APjAAAUMhN+Mnaw5pgmMnlemyxM59I0w91QselzaUcHT7B4E3JM/T6NN pOo46IuyKBVtBjDBsr/OyzM= X-Google-Smtp-Source: APXvYqxb/QKUOKCfIUo/cd7QVp5VmuKnBbu6ntZVkaaRPSS8PzKxwL8FQNy+XW+9HYJklyaakI2jEA== X-Received: by 2002:a63:d252:: with SMTP id t18mr26309447pgi.131.1557671051996; Sun, 12 May 2019 07:24:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190512135418.GN23599@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14118 Archived-At: On 2019-05-12, Rich Felker wrote: >On Sun, May 12, 2019 at 09:51:07AM -0400, Rich Felker wrote: >> On Sun, May 12, 2019 at 09:50:50AM +0800, Fangrui Song wrote: >> > >> > --- >> > ldso/dynlink.c | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/ldso/dynlink.c b/ldso/dynlink.c >> > index 42a5470d..ad0cdba2 100644 >> > --- a/ldso/dynlink.c >> > +++ b/ldso/dynlink.c >> > @@ -86,7 +86,6 @@ struct dso { >> > size_t relro_start, relro_end; >> > uintptr_t *new_dtv; >> > unsigned char *new_tls; >> > - volatile int new_dtv_idx, new_tls_idx; >> > struct td_index *td_index; >> > struct dso *fini_next; >> > char *shortname; >> > -- >> > 2.21.0 >> >> Looks ok. Your mail client seems to have corrupted the patch though; >> git am is rejecting it for some reason. I'll apply it manually. In the >> future if you can't get your mail client to send patches inline >> without breaking the formatting, attachments are fine/preferred. > >For future reference, I found what happened: it seems to have removed >the leading space at the beginning of the context lines (lines with no >+ or -). > >Rich Weird. I created the patch with `git format-patch --stdout -1 HEAD`, sent an email with neomutt to myself, then resent (e) it to the musl mailing list. Just now I checked my copy of the sent mail has the desired leading \t. I'll just attach a text/x-diff file next time.