From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14173
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Rich Felker <dalias@libc.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Hijacking malloc called within musl libc
Date: Mon, 3 Jun 2019 16:18:59 -0400
Message-ID: <20190603201859.GC1506@brightrain.aerifal.cx>
References: <CAKsLdYyB+xeLF42O010cE6VQEWtcLPhuWRj4_mY4dJ4Vn699ZQ@mail.gmail.com>
 <20190530222959.GU16415@port70.net>
 <CAKsLdYw=aG95w5tWD9_-KNKZid-cM=DvCS9huWaADVT-_ONK1g@mail.gmail.com>
 <20190531114317.GV16415@port70.net>
 <20190531133424.GO23599@brightrain.aerifal.cx>
 <CAKsLdYwQYZ0t1xooGy98FFF8LS9GHv3tHdsaZAanDze8x_5sng@mail.gmail.com>
Reply-To: musl@lists.openwall.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="262753"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Mutt/1.5.21 (2010-09-15)
To: musl@lists.openwall.com
Original-X-From: musl-return-14189-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 03 22:19:15 2019
Return-path: <musl-return-14189-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.89)
	(envelope-from <musl-return-14189-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1hXtQJ-0016Fi-Ji
	for gllmg-musl@m.gmane.org; Mon, 03 Jun 2019 22:19:15 +0200
Original-Received: (qmail 10035 invoked by uid 550); 3 Jun 2019 20:19:13 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 10015 invoked from network); 3 Jun 2019 20:19:12 -0000
Content-Disposition: inline
In-Reply-To: <CAKsLdYwQYZ0t1xooGy98FFF8LS9GHv3tHdsaZAanDze8x_5sng@mail.gmail.com>
Original-Sender: Rich Felker <dalias@aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:14173
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/14173>

On Mon, Jun 03, 2019 at 02:46:01PM -0400, sva sva wrote:
> I am in fact using version 1.1.19 and don't have the option to upgrade to
> 1.1.20. My config.mak file also contains the option -Bsymbolic-functions in
> the LDFLAGS_AUTO variable.

1.1.20 was the first version that supported malloc interposition, and
some related bugs were fixed in the next 1 or 2 versions. Just
removing -Bsymbolic-functions is not sufficient to make it safe.

Rich


> On Fri, May 31, 2019 at 9:34 AM Rich Felker <dalias@libc.org> wrote:
> 
> > On Fri, May 31, 2019 at 01:43:17PM +0200, Szabolcs Nagy wrote:
> > > * sva sva <azharivs@gmail.com> [2019-05-31 00:13:27 -0400]:
> > > > I am interposing all malloc/calloc/realloc/free/memalign but still the
> > > > realloc in scandir gets called from musl's libc. Does that make sense?
> > >
> > > no.
> > >
> > > it works for me as expected.
> > >
> > > you need to write down what you did, what you expected and what you got
> > instead.
> > > (how did you verify that the musl internal realloc gets called?
> > > it can be a bug in your interposer, in your static linker, in ...)
> >
> > It's almost certainly a matter of using a pre-1.1.20 version of musl,
> > or having an old config.mak from pre-1.1.20 musl (with
> > -Bsymbolic-functions) rather than re-running configure with the
> > current version.