From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14193 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Date: Fri, 7 Jun 2019 01:31:02 -0400 Message-ID: <20190607053102.GP1506@brightrain.aerifal.cx> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607051444.20316-2-petr.vorel@gmail.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="72697"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14209-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 07:31:16 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZ7TA-000Iol-9g for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 07:31:16 +0200 Original-Received: (qmail 3990 invoked by uid 550); 7 Jun 2019 05:31:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 3967 invoked from network); 7 Jun 2019 05:31:13 -0000 Content-Disposition: inline In-Reply-To: <20190607051444.20316-2-petr.vorel@gmail.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14193 Archived-At: On Fri, Jun 07, 2019 at 07:14:44AM +0200, Petr Vorel wrote: > following kernel definition, this fixes size on mips. > > Signed-off-by: Petr Vorel > --- > include/sys/mtio.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/sys/mtio.h b/include/sys/mtio.h > index f16a529b..4dd4c548 100644 > --- a/include/sys/mtio.h > +++ b/include/sys/mtio.h > @@ -54,8 +54,8 @@ struct mtget { > long mt_dsreg; > long mt_gstat; > long mt_erreg; > - int mt_fileno; > - int mt_blkno; > + daddr_t mt_fileno; > + daddr_t mt_blkno; > }; > > #define MT_ISUNKNOWN 0x01 > -- > 2.21.0 Can you explain what problem this is supposed to fix? It definitely needs further discussion to determine what the right way is, but that's impossible without knowing the problem you're trying to solve. Rich