From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14194 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Petr Vorel Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Date: Fri, 7 Jun 2019 07:42:15 +0200 Message-ID: <20190607054214.GA7177@x230> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607051444.20316-2-petr.vorel@gmail.com> <20190607053102.GP1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120022"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14210-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 07:42:33 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZ7e4-000V4u-P5 for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 07:42:32 +0200 Original-Received: (qmail 15704 invoked by uid 550); 7 Jun 2019 05:42:30 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 15686 invoked from network); 7 Jun 2019 05:42:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MycNL32Ly2vA9hM/5Cj3zpT5wI4726kUvG1ogMhCZd0=; b=IcEnC+HGlqrG5ks29wOgnCkHHRdJFjHefkhemwsCOWorTqUSTEnafQfuKA074NVun0 aDdEOba2Iibke4Wj+hDvePC91IaEx+rnrMfEFq+6T3chf0YkoAHCXDd5mwXWEeBSsfJX 0ntAggtkM8KfuiM+6E7MOLgkEW58t6pQ15O4RlZA9qZ11Box1irEwhpCQNv8dCF9Res2 8KRdQeDml7bRxb0CvepcEDhIWL2YM0Gzc7dq2MZI+sSs4sdoLC9Roq/S0fFj05cLee5H Rw0QRt63wH8Z5a48PKaC1g4OmsOLhhFfoROH40UhSHJ0+z1rNe7F4uwAKEhpN7xP4j8k j8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=MycNL32Ly2vA9hM/5Cj3zpT5wI4726kUvG1ogMhCZd0=; b=MzncZwGgFwtfZ5hF05AFgOQZxulaQX8PiHh7CP0vVt/7qCk8/X/OttbEc6ba2jj9ai RNSnZn4O+syRtlJIL6XwULpIUq2jV6b+0f4iRHU0pcSBa5QNwAzwRNHpjHgeBKxFRCO2 P3g4XvVzcnKjOJ4BI20t6RZobQRzuYK2Z4qkri0+o2crdzqWncJhUufWIaxDaeauNcxf oPKUPEB0Lxbiuh+xBzR1yohQCjq09ni/p98OoT1LuDMJojB7l6w4uPPXlMWr+Eu0RK5R /KGQLR8Ez5BOu8zswnlwvo8SsGinroRPVohKvrNVHGo9S5trleFA89USygvhXUIFrKFT kQag== X-Gm-Message-State: APjAAAV+C+bmvHS4EQ2J4HH0GaLLSOCqh+QFs4ALh6CpZMJ5TOW9IX3N CPzNpVTVng2cJpw03Cf/g1o5OdCt X-Google-Smtp-Source: APXvYqyvwqCs7ih/tiyEmxEszmSNf93NkjN4QRCzjg9MfmuB9uVEpixTZdHzZzL5Egn0LdfwWQYWCg== X-Received: by 2002:adf:dd51:: with SMTP id u17mr17709078wrm.218.1559886138175; Thu, 06 Jun 2019 22:42:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190607053102.GP1506@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14194 Archived-At: Hi Rich, ... > > +++ b/include/sys/mtio.h > > @@ -54,8 +54,8 @@ struct mtget { > > long mt_dsreg; > > long mt_gstat; > > long mt_erreg; > > - int mt_fileno; > > - int mt_blkno; > > + daddr_t mt_fileno; > > + daddr_t mt_blkno; ... > Can you explain what problem this is supposed to fix? It definitely > needs further discussion to determine what the right way is, but > that's impossible without knowing the problem you're trying to solve. Thanks for review. Not a problem for me actually. I've noticed, that glibc (and thus uclibc-ng) and bionic follow kernel sources, which defines it long for mips (and for sparc, but musl doesn't support it). Default is int [2]. Drop this patch if this is not an issue. > Rich Kind regards, Petr [1] https://elixir.bootlin.com/linux/latest/source/arch/mips/include/uapi/asm/posix_types.h#L21 [2] https://elixir.bootlin.com/linux/latest/source/include/uapi/asm-generic/posix_types.h#L45