From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14195 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Date: Fri, 7 Jun 2019 01:50:51 -0400 Message-ID: <20190607055051.GQ1506@brightrain.aerifal.cx> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607051444.20316-2-petr.vorel@gmail.com> <20190607053102.GP1506@brightrain.aerifal.cx> <20190607054214.GA7177@x230> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153762"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14211-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 07:51:05 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZ7mL-000dvT-Jj for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 07:51:05 +0200 Original-Received: (qmail 24351 invoked by uid 550); 7 Jun 2019 05:51:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24327 invoked from network); 7 Jun 2019 05:51:03 -0000 Content-Disposition: inline In-Reply-To: <20190607054214.GA7177@x230> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14195 Archived-At: On Fri, Jun 07, 2019 at 07:42:15AM +0200, Petr Vorel wrote: > Hi Rich, > > .... > > > +++ b/include/sys/mtio.h > > > @@ -54,8 +54,8 @@ struct mtget { > > > long mt_dsreg; > > > long mt_gstat; > > > long mt_erreg; > > > - int mt_fileno; > > > - int mt_blkno; > > > + daddr_t mt_fileno; > > > + daddr_t mt_blkno; > .... > > > Can you explain what problem this is supposed to fix? It definitely > > needs further discussion to determine what the right way is, but > > that's impossible without knowing the problem you're trying to solve. > Thanks for review. Not a problem for me actually. I've noticed, that glibc (and > thus uclibc-ng) and bionic follow kernel sources, which defines it long for mips > (and for sparc, but musl doesn't support it). Default is int [2]. Drop this > patch if this is not an issue. Well it might be a problem on some archs. I think it's worth looking into. We might need to add bits/mtio.h to define it appropriately for the arch. Rich