From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14197 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Petr Vorel Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Date: Fri, 7 Jun 2019 07:58:29 +0200 Message-ID: <20190607055828.GC7177@x230> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607051444.20316-2-petr.vorel@gmail.com> <20190607053102.GP1506@brightrain.aerifal.cx> <20190607054214.GA7177@x230> <20190607055051.GQ1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185784"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14213-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 07:58:45 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZ7tl-000mDr-G7 for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 07:58:45 +0200 Original-Received: (qmail 1340 invoked by uid 550); 7 Jun 2019 05:58:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 1322 invoked from network); 7 Jun 2019 05:58:43 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2AdXWON7QCVqCAf00+ByekmIug4r6F2TxZs8APGKHg0=; b=KwTZDvoTKymeGwrC+lotCeHMR0rD8BDvYURuaZDuM22Bc2xZ3jSDsBav9pQKqOBPQY FgP1Q1Oel2jOicwv7HZetC4fnH+n43zERlxOwWLPoVLtAL0HLpAzt1ODPmpl1BfFmgof gUb7mO603v/LzUDlhdf5+JmgX4be8eJNjHz7l5/XZrp2lca/MxH92VAfA0HQdIVr5eik S8J3psAOdDoZKpg5x97OG904gbqANT9N0MFzQXVxwdjZNOrH/54C9mNDVcJS0gFxnjbi /TOFLzOOR/TN/k7rLVE4ic8MCpjpqPIdxxlwXjhzK4yZ+0f7zUc+qmFDw154GZVzjhPw LKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2AdXWON7QCVqCAf00+ByekmIug4r6F2TxZs8APGKHg0=; b=OYeUHbQQPlbi+1CtQhQ47rTWLHRjpR1fafJx+nuRnXT6wzmu70tEG0tQPtnLHPyeI4 ze3sKFpzU3Fbm6jRCmukZ81QziTfIIyEsKnipKRXywKAM6RxeURSjXSQA5Oavw3wuFGQ bjU2r43xCqySMOji2lb5P+9WLn5nx9SiAKSbBms5NWXSHoJZvCGCPHs5SwW6Ih1GYLJq F2hpwI/+IdrqWuIBxeDfWWsyIC3sYjyEUvy34j0c+dgzyPC9HdSYsfV6tDs1mB9NPyUb oGxeRe9dQYGKebiONL/9rjcqUeMmwy/Dow3P6WUutyQ/GizAU70q2+9psQCsm8JVn9gk 7wbw== X-Gm-Message-State: APjAAAWtT58R4sFFTXH4DmgeE7lo2N2JzREMsOfEnzmLqZvvSYON4Pzw RXsJLfBvPG78/gvh3PNpxzSMweC2 X-Google-Smtp-Source: APXvYqyCq8kBpCiBhSownLuUUQalsvAO2wIYCrol3Lwt8ShXLEWhijnVa9CDrjYuVeuzHaLEjQQNiA== X-Received: by 2002:a5d:6949:: with SMTP id r9mr17444808wrw.73.1559887111521; Thu, 06 Jun 2019 22:58:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190607055051.GQ1506@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14197 Archived-At: Hi Rich, > > .... > > > > +++ b/include/sys/mtio.h > > > > @@ -54,8 +54,8 @@ struct mtget { > > > > long mt_dsreg; > > > > long mt_gstat; > > > > long mt_erreg; > > > > - int mt_fileno; > > > > - int mt_blkno; > > > > + daddr_t mt_fileno; > > > > + daddr_t mt_blkno; > > .... > > > Can you explain what problem this is supposed to fix? It definitely > > > needs further discussion to determine what the right way is, but > > > that's impossible without knowing the problem you're trying to solve. > > Thanks for review. Not a problem for me actually. I've noticed, that glibc (and > > thus uclibc-ng) and bionic follow kernel sources, which defines it long for mips > > (and for sparc, but musl doesn't support it). Default is int [2]. Drop this > > patch if this is not an issue. > Well it might be a problem on some archs. I think it's worth looking > into. We might need to add bits/mtio.h to define it appropriately for > the arch. I'd be for bits/mtio.h as I suppose this problem still persists on mips. But I'm not able to verify, just follow what it's defined in kernel/glibc/uclibc/bionic. My main concern is to have daddr_t defined in musl. > Rich Kind regards, Petr