From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14200 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Petr Vorel Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/2] define daddr_t type Date: Fri, 7 Jun 2019 08:06:20 +0200 Message-ID: <20190607060619.GD7177@x230> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607052850.GO1506@brightrain.aerifal.cx> <20190607055329.GB7177@x230> <20190607055849.GR1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="220094"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14216-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 08:06:38 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZ81M-000v3M-HE for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 08:06:36 +0200 Original-Received: (qmail 13436 invoked by uid 550); 7 Jun 2019 06:06:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13416 invoked from network); 7 Jun 2019 06:06:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=47unfd8sOByxZPTqtbLvJF9RAkQ69957NzGLL170E5E=; b=DL2M1QsyXxU5ZPzSq1ZiG+PZvh4eDbT9tTmg32UYbNpejFVx10Y6eZL7+63LvIIJVp Hh86m5jdISumnovB9BgALUOqE/TVEnvn2IO6UY7Wrdo/X8yZBa6+558BSDi9NxxJySsZ tUBidvuIEzFP9IxGIfwFunlEe0qcZ0owplNu5K+OS0KRe8A6WdAnCjjyF9txZbZaI7Gl NcJFn0bQGRlcXwmm3ryPKtCcGyZS1/FqnPOuZXGPvh08BbZyQhRty2k5qn0VF4G3MOWI iojiNyv1H/4BRYSI1Et4mds5ipHZYILhHXfHomIszCLvklnfAElXl5haPHonlLvjgOT1 G9qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=47unfd8sOByxZPTqtbLvJF9RAkQ69957NzGLL170E5E=; b=bp+NPYopPdqKJ3KkgXCXWFMuDLH/ue++wIwdBL4UDibC0tWxSAuCT3RhU+rl0A8jMZ rGEgfAsx7R2vRDmD5sQdqRXx0x9LjqUhRLINP64yhIGRdDN6upYgEfdnEdYy1NAPQaPh U1J5/2Rl6Jo7w2sSYgsaQxt398Q5Y4l1IX5QyXAvQRSf8FVKS4EVkq4m5OG95ZHVsJ+j ZE/Kz9yu/Zc26Kx9HqvXEHd8peC4xdek6EnLwiYMKkcnPtGcvdacAQxg+qwYWTCnZ7vD up4926HvcEX1V0PhdGcNT0ZVgiJ80CVrbI04lmpAzTo05hNhxgS+Ecsj0KovSLkxYnaX TbmQ== X-Gm-Message-State: APjAAAWUcSurY4eSlyInYBK7NStGDgXsCCgoWgz2tNZTpH7v2tFrrW1v WWUEprPfDqdZ9eG0NWmA/Y22l29w X-Google-Smtp-Source: APXvYqzs6jo653Fu52FYOz0gI6hzLDi6R5Ju+DqUiywddJFsKT9YTboh3IxrK1EYhN/sQ9VK9+HDMA== X-Received: by 2002:a5d:53c7:: with SMTP id a7mr17924864wrw.91.1559887582511; Thu, 06 Jun 2019 23:06:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190607055849.GR1506@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14200 Archived-At: Hi Rich, > > .... > > > > +++ b/include/sys/types.h > > > > @@ -29,6 +29,7 @@ extern "C" { > > > > #define __NEED_clock_t > > > > #define __NEED_suseconds_t > > > > #define __NEED_blksize_t > > > > +#define __NEED_daddr_t > > .... > > > daddr_t is not a standard type, so can't be exposed by default here > > > (aside from the dubious "*_t is always reserved" rule), and it's only > > So should it be wrapped by #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) ? > > > proposed to be used in one header, so it doesn't belong in alltypes.h > > > either. > > Where should it be then? Shell I create bits/types.h for it? > > The goal is to be loadable from > Why? It's not a reasonable type for any application to use -- we've > never gotten a report that something failed to build because of its > absence, and even if we did, it would almost surely be a case of "fix > the application". It looks like the only reason you wanted it was to > fix the type of a field in an mtio structure, and in that case the > type would just need to be defined in mtio.h. I need it for LTP [1]. It's actually workaround for missing struct ustat [2]. If it's really useless to have it in musl, I'll use in LTP __kernel_daddr_t from . [1] https://patchwork.ozlabs.org/patch/1102380/ [2] https://github.com/linux-test-project/ltp/blob/master/include/lapi/ustat.h > Rich Kind regards, Petr