From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14233
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Rich Felker <dalias@libc.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Removing sys/sysmacros.h from sys/types.h
Date: Fri, 14 Jun 2019 17:15:02 -0400
Message-ID: <20190614211502.GJ1506@brightrain.aerifal.cx>
References: <CAJwEmmot0y6iaAA88tCB6anUOiqSbsV3AhFYhk__MHb1XAw3CA@mail.gmail.com>
Reply-To: musl@lists.openwall.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="246381"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Mutt/1.5.21 (2010-09-15)
To: musl@lists.openwall.com
Original-X-From: musl-return-14249-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 14 23:15:19 2019
Return-path: <musl-return-14249-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.89)
	(envelope-from <musl-return-14249-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1hbtXb-0011v6-5D
	for gllmg-musl@m.gmane.org; Fri, 14 Jun 2019 23:15:19 +0200
Original-Received: (qmail 21810 invoked by uid 550); 14 Jun 2019 21:15:15 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 21788 invoked from network); 14 Jun 2019 21:15:15 -0000
Content-Disposition: inline
In-Reply-To: <CAJwEmmot0y6iaAA88tCB6anUOiqSbsV3AhFYhk__MHb1XAw3CA@mail.gmail.com>
Original-Sender: Rich Felker <dalias@aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:14233
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/14233>

On Fri, Jun 14, 2019 at 01:20:21PM -0700, Benjamin Wright wrote:
> Hello,
> 
> Would it be possible to remove the sys/sysmacros.h include from sys/types.h?
> 
> This change was added in 2011 -
> https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
> 
> However it appears to have been removed from other standard libc
> implementations around ~2015 based on this announcement:
> https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
> 
> This can cause issues with user defined symbol collision of the symbols
> major, minor or makedev.

Yes, I'd actually forgotten we did this. I'll remove it right away in
time for the next release.

Rich