From: Sergei Trofimovich <slyfox@gentoo.org>
To: musl@lists.openwall.com
Subject: return-value/errno for utimensat(<filefd>, NULL, NULL, 0) mismatch across musl and glibc: bug or a feature?
Date: Tue, 25 Jun 2019 21:35:25 +0100 [thread overview]
Message-ID: <20190625213525.0407b535@sf> (raw)
Hi musl@ folk!
The original issue popped in https://bugs.gentoo.org/549108#c22.
There glibc's utimensat() wrapper handles one corner case differently
from musl's wrapper.
Here is the minimal reproducer:
$ cat a.c
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <stddef.h>
int main() {
int fd = open("f", O_WRONLY|O_CREAT, 0666);
return utimensat(fd, NULL, NULL, 0);
}
On glibc (x86_64 linux-5.2-rc5):
$ gcc a.c -o a && strace -etrace=open,openat,utimensat,exit_group ./a
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "f", O_WRONLY|O_CREAT, 0666) = 3
exit_group(-1) = ?
+++ exited with 255 +++
On musl (x86_64 linux-5.2-rc5):
$ gcc a.c -o a && strace -etrace=open,openat,utimensat,exit_group ./a
open("f", O_WRONLY|O_CREAT, 0666) = 3
utimensat(3, NULL, NULL, 0) = 0
exit_group(0) = ?
The difference stems from this extra check in glibc:
https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/utimensat.c;h=04b549f360b88a7e7c1e5e617158caf73299736b;hb=HEAD#l32
int utimensat (int fd, const char *file, const struct timespec tsp[2], int flags)
{
if (file == NULL)
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
/* Avoid implicit array coercion in syscall macros. */
return INLINE_SYSCALL (utimensat, 4, fd, file, &tsp[0], flags);
}
while musl just calls the syscall directly:
https://git.musl-libc.org/cgit/musl/tree/src/stat/utimensat.c
int utimensat(int fd, const char *path, const struct timespec times[2], int flags)
{
int r = __syscall(SYS_utimensat, fd, path, times, flags);
// ...
return __syscall_ret(r);
}
Is this divergence expected? Or maybe it's accidental? Does it make
sense to handle non-directory fds in utimensat() according to POSIX?
I wonder if we should drop the unstable test or some of libc implementations
actually deviates from the spec.
Thank you!
--
Sergei
next reply other threads:[~2019-06-25 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 20:35 Sergei Trofimovich [this message]
2019-06-25 21:25 ` Rich Felker
2019-06-27 6:46 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625213525.0407b535@sf \
--to=slyfox@gentoo.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).