From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14283 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction Date: Sat, 29 Jun 2019 00:19:24 -0400 Message-ID: <20190629041924.GI1506@brightrain.aerifal.cx> References: <20180824193052.GD4418@port70.net> <20180824232027.GO1878@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102860"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14299-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jun 29 06:19:47 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hh4q3-000QfB-1a for gllmg-musl@m.gmane.org; Sat, 29 Jun 2019 06:19:47 +0200 Original-Received: (qmail 23593 invoked by uid 550); 29 Jun 2019 04:19:44 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23563 invoked from network); 29 Jun 2019 04:19:43 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14283 Archived-At: On Fri, Jun 28, 2019 at 03:55:56PM -0700, Andre McCurdy wrote: > On Fri, Aug 24, 2018 at 4:20 PM Rich Felker wrote: > > On Fri, Aug 24, 2018 at 02:58:04PM -0700, Andre McCurdy wrote: > > > On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy wrote: > > > > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t. > > > > > > That conditional was originally written under the assumption that musl > > > doesn't support thumb1 (so -mthumb -march=armv5t is not a supported > > > configuration). > > > > > > Was that assumption wrong? > > > > musl does not support being pure-thumb1 code, because some of the asm > > source files are not thumb-compatible, but I think the C code can be > > compiled as thumb1. -mthumb is only passed to the assembler for asm > > source files if __thumb2__ is defined. > > Sorry to resurrect such an old thread, but it seems this patch was > never applied? > > Without it, -mthumb -march=armv5t still fails to build due to clz > getting into C code via inline assembler. Thanks for reviving this thread. I'll commit it or something similar. I wonder if _ARM_ARCH>=5 && __thumb__!=1 would be a better test. Rich