From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14294 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Samuel Holland Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH 2/2] use the correct attributes for ___errno_location Date: Sat, 29 Jun 2019 16:22:44 -0500 Message-ID: <20190629212244.42963-3-samuel@sholland.org> References: <20190629212244.42963-1-samuel@sholland.org> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75479"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Samuel Holland To: musl@lists.openwall.com Original-X-From: musl-return-14310-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jun 29 23:23:07 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hhKoL-000JU2-Br for gllmg-musl@m.gmane.org; Sat, 29 Jun 2019 23:23:05 +0200 Original-Received: (qmail 13456 invoked by uid 550); 29 Jun 2019 21:22:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13412 invoked from network); 29 Jun 2019 21:22:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=y8Ovxwzltu6KE WZl+WToer+v0KA9po7AVdMHQEBi/lg=; b=Uw2XCwBSNJtxAAOIyeXRc4EuskSoZ 1J8AkILdEh4es1HcY9vsz+mjOTuxVUFOdvJvArApqbqDMaStatEOPjTvbuTfaSQr z2M8SjaDI2YtKiXdHvM6fdSrCvizQXBwJ3jHEz8LB2jbiNtZbPK16mby4CLj+oCF lxeDnS0WauCCYBbe1P6REH7cUrenn7VulB+pQiBdCudrN14hcGr69udPipWyfNLa oVOAy8wAbVLcsxCsAUxp/cx57PqjnJ9vwW5LxINQ0NAEKoEuIH2EavisayE9DIX6 gd3C5G4zraQfmcC0Bc4KEk+Co3eQtaExz398M5bdVHKi9FLrq6ZsozJgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=y8Ovxwzltu6KEWZl+WToer+v0KA9po7AVdMHQEBi/lg=; b=CD9QwUft CledDUi2D5Oc09An0ebpxecIDpriKTt45gIB2qv1Z6K9ax1BCqX3KLca+sVp3C/T il7wqqLoBZFZOgZZCAb273Ei/c4pfCwO8jXrHkPgFBw8P2rzY+bIe8ScwqBldhW7 qfZA5YhCY+8QGvUpO4cM9p4WHMtIHGp6s33K0+rY6LKqBCnnFJOb0m8nsm7YOVgP Etzn1VJQfHrtW/CvhGKGOjS2UHhY6WARsYdhYbOECbO7aOfKjDhv4mjJQTI6AjAZ H12ONK+ciTHiST52xCnH7ocCWOKDTmeYJOW27WSXdTfmsnDM56dx8W+5Zm1Kkycl 31qIWk4ThkVL6w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvddvgdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepufgrmhhuvghlucfjohhllhgrnhguuceoshgrmhhuvghlsehs hhholhhlrghnugdrohhrgheqnecukfhppeejtddrudefhedrudegkedrudehudenucfrrg hrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghnugdrohhrghenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190629212244.42963-1-samuel@sholland.org> Xref: news.gmane.org gmane.linux.lib.musl.general:14294 Archived-At: In the public header, __errno_location is declared with the "const" attribute, conditional on __GNUC__. Ensure that its internal alias has the same attributes. --- src/errno/__errno_location.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/errno/__errno_location.c b/src/errno/__errno_location.c index 7f9d6027..b59919c3 100644 --- a/src/errno/__errno_location.c +++ b/src/errno/__errno_location.c @@ -6,4 +6,8 @@ int *__errno_location(void) return &__pthread_self()->errno_val; } -weak_alias(__errno_location, ___errno_location); +weak_alias(__errno_location, ___errno_location) +#ifdef __GNUC__ +__attribute__((const)) +#endif +; -- 2.21.0