From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14348 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove stray .end directives Date: Tue, 2 Jul 2019 12:58:41 -0400 Message-ID: <20190702165841.GZ1506@brightrain.aerifal.cx> References: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254014"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14364-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jul 02 18:58:58 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hiM7N-0013xt-UW for gllmg-musl@m.gmane.org; Tue, 02 Jul 2019 18:58:58 +0200 Original-Received: (qmail 31843 invoked by uid 550); 2 Jul 2019 16:58:55 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 31824 invoked from network); 2 Jul 2019 16:58:54 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14348 Archived-At: On Tue, Jul 02, 2019 at 01:09:46PM +0000, Song Fangrui wrote: > This fixes an error when building musl powerpc{32,64} with clang > (it doesn't know GNU as ignores .end arguments): > > ../src/ldso/powerpc/dlsym.s:8:10: error: unexpected token in '.end' directive > .end dlsym > > I'm not sure if .size dlsym, .-dlsym should also be deleted to be > consistent with other archs. > From 1e8f793a4e191dd86c55f47a8e4ef8d76d773c1a Mon Sep 17 00:00:00 2001 > From: Fangrui Song > Date: Mon, 1 Jul 2019 09:42:49 +0000 > Subject: [PATCH] remove stray .end directives > > --- > src/ldso/powerpc/dlsym.s | 1 - > src/ldso/powerpc64/dlsym.s | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/ldso/powerpc/dlsym.s b/src/ldso/powerpc/dlsym.s > index 357d5771..cfe308ef 100644 > --- a/src/ldso/powerpc/dlsym.s > +++ b/src/ldso/powerpc/dlsym.s > @@ -5,5 +5,4 @@ > dlsym: > mflr 5 # The return address is arg3. > b __dlsym > - .end dlsym > .size dlsym, .-dlsym > diff --git a/src/ldso/powerpc64/dlsym.s b/src/ldso/powerpc64/dlsym.s > index 7eb691d9..a14715fd 100644 > --- a/src/ldso/powerpc64/dlsym.s > +++ b/src/ldso/powerpc64/dlsym.s > @@ -8,5 +8,4 @@ dlsym: > .localentry dlsym,.-dlsym > mflr 5 # The return address is arg3. > b __dlsym > - .end dlsym > .size dlsym, .-dlsym This sounds right. Before I remove this, anyone have any idea what the purpose of these was to begin with? Rich