From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14349 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Markus Wichmann Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove stray .end directives Date: Tue, 2 Jul 2019 19:53:53 +0200 Message-ID: <20190702175353.GD22788@voyager> References: <20190702165841.GZ1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219608"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14365-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jul 02 19:54:12 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hiMym-000urn-SQ for gllmg-musl@m.gmane.org; Tue, 02 Jul 2019 19:54:08 +0200 Original-Received: (qmail 26422 invoked by uid 550); 2 Jul 2019 17:54:06 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 26401 invoked from network); 2 Jul 2019 17:54:05 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1562090034; bh=PoDrF071cmGM4bHJ/SAjPdIf3IeVuPi66Bm9LAXp3Os=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=fChzQO0iLaEkujsGC8hM40kICqGHJFRAgiMarGVi+vKNREZmvUjEkMnNfwGK/mIaZ igtV/sJENF+xuR9mqpijLrv6G3ZnQGixRrKUzjLdwsF9t2Lg9uLTwM7ao7CqpWWdGg 1lOJcJkjQCHJYdJeaKaqJJNJ59qngS5gWlc3muyk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Content-Disposition: inline In-Reply-To: <20190702165841.GZ1506@brightrain.aerifal.cx> X-Provags-ID: V03:K1:srkNVG7QhIVjUhDuvoS1mOE988qRdsg7/4YdoYd/UfjNOERJ1XL YB1CDweZj+zlfkws+VZH1MjGBJOsJ/TBL6vC7T2qn19RuZZi2IT7so1rVBp3zvV6kq16u/P 2pNJVH6mHjXccAtNJoR2m9WQcYwRcyhD3hD8TtKvJVb9VUhC5GYYyBtjYEf2nHWeOXv1+LA R79tJwEfr8I/fGdk1petg== X-UI-Out-Filterresults: notjunk:1;V03:K0:F+j1heTa2CE=:aXuI2W6koP+qjd3vGWsQfa zhjjFrm7mvIp5OgVRHZy6X8LFm2sB8wvdaD8X34dc8yjYzl1F6n8yAcI9zeeSv2CwaPcA1KlQ 5u+ddxQ3zarbEiWcfPoQgthCTu5bXffdiD6P0YDH6vdwYk4O4B9VWtWpn4yKZDn+HkZMPhQgA bAR8qWTTW+gf6SKL/URdO4UIZfTw6WA63NZOLg6Rr8losokAU4kMGMJnTLuhvwpU+hIJ3FiTk icB7vXq4N3p9aahvkSJAwLWK3qK89HXNAzoKzxI4gMXvEELorh2kPQ0P3BLQNjvBupd5+QmJm NTGkdK2gJYdtkmo5uKAB2aYOPjgDL9z6uQPai/2JMNWbGczSIYRHmtFiVeSQGfnPa5cCv/f9i umOyI1iA2LK+/h/y/AtltGKgVti+g1foiYZnMlESF1AszZfVuNyrno+5GUGxa0I66s84lieq6 hLSKuQ+od6IMlYOBw2efETbxZi3U5YkEVyUtXqSmK8bh2XAz8ZvqmKs7Z2d9JO5kcP8+UcVle 9iZo8QzA0kM8IA+/D3RrHliIBoM+aP1pDTgDQPQtLGBDjQXqCCPLcgTiAwr6TThUST3qWy4Wv vPy88o5GqgUQqQwVcrFfLrKHfR2n46SSSdEmfbsebHRcMfrt6JaiirouEUJukYuxabRcJ3QnX XFN6M3T6Ow8DyoLhVIpLgcynNNuYxFjVxAV3UB8dQt4y8YCcPEAckSW7b37IGiEXKWNgFBjBI i+xhfarddfVzJXRTofLSmorn0Y2JdLbCl3/BaerIIEkGlKBrqOywNxeldS/UD463Fv7EVxwW Xref: news.gmane.org gmane.linux.lib.musl.general:14349 Archived-At: On Tue, Jul 02, 2019 at 12:58:41PM -0400, Rich Felker wrote: > On Tue, Jul 02, 2019 at 01:09:46PM +0000, Song Fangrui wrote: > > diff --git a/src/ldso/powerpc64/dlsym.s b/src/ldso/powerpc64/dlsym.s > > index 7eb691d9..a14715fd 100644 > > --- a/src/ldso/powerpc64/dlsym.s > > +++ b/src/ldso/powerpc64/dlsym.s > > @@ -8,5 +8,4 @@ dlsym: > > .localentry dlsym,.-dlsym > > mflr 5 # The return address is arg3. > > b __dlsym > > - .end dlsym > > .size dlsym, .-dlsym > > This sounds right. Before I remove this, anyone have any idea what the > purpose of these was to begin with? > > Rich I can't tell you the purpose, but I can tell you the effect: This directive ends assembly parsing. Therefore the .size directive below them was never in effect before (if the documentation is to be trusted). Dunno if that has any apparent effect though (besides the output of objdump). The PPC64 file was added in one go by Bobby Bingham in 2016. I guess the line there is for consistency with PPC32. The PPC32 file was added in 2012 by rofl0r, though the blame also shows one Richard Pennington (not the log, though). Weird. Anyway, the log message is also not very enlightening. I can only assume the line was added in error. That, or the .size directive. Together they make no sense. Ciao, Markus