From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14350 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove stray .end directives Date: Tue, 2 Jul 2019 17:03:23 -0400 Message-ID: <20190702210323.GA1506@brightrain.aerifal.cx> References: <20190702165841.GZ1506@brightrain.aerifal.cx> <20190702175353.GD22788@voyager> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200285"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14366-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jul 02 23:03:40 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hiPwB-000pwl-Es for gllmg-musl@m.gmane.org; Tue, 02 Jul 2019 23:03:39 +0200 Original-Received: (qmail 19664 invoked by uid 550); 2 Jul 2019 21:03:36 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 19646 invoked from network); 2 Jul 2019 21:03:35 -0000 Content-Disposition: inline In-Reply-To: <20190702175353.GD22788@voyager> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14350 Archived-At: On Tue, Jul 02, 2019 at 07:53:53PM +0200, Markus Wichmann wrote: > On Tue, Jul 02, 2019 at 12:58:41PM -0400, Rich Felker wrote: > > On Tue, Jul 02, 2019 at 01:09:46PM +0000, Song Fangrui wrote: > > > diff --git a/src/ldso/powerpc64/dlsym.s b/src/ldso/powerpc64/dlsym.s > > > index 7eb691d9..a14715fd 100644 > > > --- a/src/ldso/powerpc64/dlsym.s > > > +++ b/src/ldso/powerpc64/dlsym.s > > > @@ -8,5 +8,4 @@ dlsym: > > > .localentry dlsym,.-dlsym > > > mflr 5 # The return address is arg3. > > > b __dlsym > > > - .end dlsym > > > .size dlsym, .-dlsym > > > > This sounds right. Before I remove this, anyone have any idea what the > > purpose of these was to begin with? > > > > Rich > > I can't tell you the purpose, but I can tell you the effect: This > directive ends assembly parsing. Therefore the .size directive below > them was never in effect before (if the documentation is to be trusted). > Dunno if that has any apparent effect though (besides the output of > objdump). > > The PPC64 file was added in one go by Bobby Bingham in 2016. I guess the > line there is for consistency with PPC32. The PPC32 file was added in > 2012 by rofl0r, though the blame also shows one Richard Pennington (not > the log, though). Weird. Anyway, the log message is also not very > enlightening. I can only assume the line was added in error. That, or > the .size directive. Together they make no sense. Thanks. Applying. Rich