From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14513 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] fix risc64 user_regs_struct conflict with kernel header Date: Tue, 6 Aug 2019 15:16:03 +0200 Message-ID: <20190806131603.GE22009@port70.net> References: <63f4c551e85a848e336f41539b6dd283396eeda7.1565070674.git.baruch@tkos.co.il> <20190806121047.GT9017@brightrain.aerifal.cx> <87imra7amk.fsf@tarshish> <20190806130129.GU9017@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24024"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14529-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 06 15:16:18 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1huzK5-0006AZ-Th for gllmg-musl@m.gmane.org; Tue, 06 Aug 2019 15:16:18 +0200 Original-Received: (qmail 28097 invoked by uid 550); 6 Aug 2019 13:16:15 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28073 invoked from network); 6 Aug 2019 13:16:15 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20190806130129.GU9017@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14513 Archived-At: * Rich Felker [2019-08-06 09:01:29 -0400]: > On Tue, Aug 06, 2019 at 03:15:47PM +0300, Baruch Siach wrote: > > On Tue, Aug 06 2019, Rich Felker wrote: > > > On Tue, Aug 06, 2019 at 08:51:14AM +0300, Baruch Siach wrote: > > >> -struct user_regs_struct { > > >> +struct _user_regs_struct { > > > > > > Does this agree with glibc naming? > > > > glibc riscv headers do not define user_regs_struct. > > Not even by including a kernel header that defines it? If so, then the the glibc sys/user.h is empty on riscv. user_regs_struct is declared in asm/ptrace.h in linux but that's not included into libc headers on riscv. i think musl's user.h should be empty too.