From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14519 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v2] remove riscv64 user_regs_struct Date: Tue, 6 Aug 2019 13:50:06 -0400 Message-ID: <20190806175006.GZ9017@brightrain.aerifal.cx> References: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162959"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14535-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 06 19:50:23 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hv3bK-000gGt-AB for gllmg-musl@m.gmane.org; Tue, 06 Aug 2019 19:50:22 +0200 Original-Received: (qmail 32176 invoked by uid 550); 6 Aug 2019 17:50:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32146 invoked from network); 6 Aug 2019 17:50:19 -0000 Content-Disposition: inline In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:14519 Archived-At: On Tue, Aug 06, 2019 at 08:47:29PM +0300, Baruch Siach wrote: > user_regs_struct removal fixes possible conflict with the kernel > definition of the same struct in asm/ptrace.h. glibc does not define > user_regs_struct for riscv either. > --- > v2: Remove user_regs_struct entirely following feedback from Rich and > Szabolcs > --- > arch/riscv64/bits/user.h | 35 ----------------------------------- > 1 file changed, 35 deletions(-) > > diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h > index bd0f0fc7027f..d2e383b24e53 100644 > --- a/arch/riscv64/bits/user.h > +++ b/arch/riscv64/bits/user.h > @@ -1,38 +1,3 @@ > -struct user_regs_struct { > - unsigned long pc; > - unsigned long ra; > - unsigned long sp; > - unsigned long gp; > - unsigned long tp; > - unsigned long t0; > - unsigned long t1; > - unsigned long t2; > - unsigned long s0; > - unsigned long s1; > - unsigned long a0; > - unsigned long a1; > - unsigned long a2; > - unsigned long a3; > - unsigned long a4; > - unsigned long a5; > - unsigned long a6; > - unsigned long a7; > - unsigned long s2; > - unsigned long s3; > - unsigned long s4; > - unsigned long s5; > - unsigned long s6; > - unsigned long s7; > - unsigned long s8; > - unsigned long s9; > - unsigned long s10; > - unsigned long s11; > - unsigned long t3; > - unsigned long t4; > - unsigned long t5; > - unsigned long t6; > -}; > - > struct user_fpregs_struct { > double f[32]; > unsigned int fcsr; > -- > 2.20.1 It's not just that struct but the whole file. I've got the removal already committed here though, pending push with a queue of stuff from the list. Thanks. Rich