From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14578 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [RFC] final time64 switch-over patch series Date: Wed, 14 Aug 2019 20:13:31 -0400 Message-ID: <20190815001331.GQ9017@brightrain.aerifal.cx> References: <20190802214433.GA25193@brightrain.aerifal.cx> <20190814235521.GP9017@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120499"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14594-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 15 02:13:47 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hy3Ok-000VF1-LS for gllmg-musl@m.gmane.org; Thu, 15 Aug 2019 02:13:46 +0200 Original-Received: (qmail 14065 invoked by uid 550); 15 Aug 2019 00:13:44 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14047 invoked from network); 15 Aug 2019 00:13:43 -0000 Content-Disposition: inline In-Reply-To: <20190814235521.GP9017@brightrain.aerifal.cx> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14578 Archived-At: On Wed, Aug 14, 2019 at 07:55:21PM -0400, Rich Felker wrote: > It should be possible to do some macro magic to make features.h do a > _T64() function-like macro that expands differently depending on the > definition of _REDIR_TIME64 at the time it's expanded, but this will > require that all archs define it to 0 or 1 rather than leaving it > undefined when not used. Then we can just unconditionally do: > > int aio_suspend(const struct aiocb *const [], int, const struct timespec *) _T64(__aio_suspend_time64); > > etc. > > Does this seem reasonable? Hm, I think it's probably simpler/more readable just to have alltypes.h define _T64(x) appropriately. I hate header mechanisms that require you to trace back across arcane stuff in multiple places to find how/where something is actually defined. Rich