From: Ismael Luceno <ismael@iodev.co.uk>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Add copy_file_range system call
Date: Tue, 20 Aug 2019 12:28:49 +0200 [thread overview]
Message-ID: <20190820102849.GA24852@pirotess.home> (raw)
In-Reply-To: <20190820005635.GC9017@brightrain.aerifal.cx>
On 19/Aug/2019 20:56, Rich Felker wrote:
<...>
> Is there a reason for the choice to put it in unistd.h? Similar
> functions seem to have gone in fcntl.h. unistd.h does not make the
> loff_t type available which could be problematic to callers using it,
> since they really should (for API compatibility) be declaring the
> objects whose addresses they pass as loff_t.
>
> If glibc does it here and exposes loff_t in unistd.h we might need to
> consider doing that too with _GNU_SOURCE.
+1. I've seen some code in the wild depend on loff_t.
next prev parent reply other threads:[~2019-08-20 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 23:41 Árni Dagur
2019-08-20 0:56 ` Rich Felker
2019-08-20 2:11 ` Rich Felker
2019-08-20 10:28 ` Ismael Luceno [this message]
2019-08-22 3:09 ` Rich Felker
2019-08-24 0:25 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820102849.GA24852@pirotess.home \
--to=ismael@iodev.co.uk \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).