From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14592 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH libc-test] tls_local_exec.c: add a dynamic relocation test case Date: Thu, 22 Aug 2019 21:36:08 +0200 Message-ID: <20190822193607.GQ22009@port70.net> References: <20190814032004.y7tdnx5pwftuzsos@gmail.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129279"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) To: musl@lists.openwall.com Original-X-From: musl-return-14608-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 22 21:36:25 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1i0ssi-000XSj-C7 for gllmg-musl@m.gmane.org; Thu, 22 Aug 2019 21:36:24 +0200 Original-Received: (qmail 5499 invoked by uid 550); 22 Aug 2019 19:36:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 5480 invoked from network); 22 Aug 2019 19:36:20 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20190814032004.y7tdnx5pwftuzsos@gmail.com> Xref: news.gmane.org gmane.linux.lib.musl.general:14592 Archived-At: * Fangrui Song [2019-08-14 03:20:04 +0000]: > commit 9d35fec9e1f391d56faee20b868ef4114bcc4d8a fixed a TLS bug introduced > in commit ffab43602b5900c86b7040abdda8ccf6cdec95f5. > > % make B=/tmp/libc-test-x86_64 /tmp/libc-test-x86_64/functional/tls_local_exec.err > ... > % cat /tmp/libc-test-x86_64/functional/tls_local_exec.err > FAIL /tmp/libc-test-x86_64/functional/tls_local_exec.exe [signal Segmentation fault] > > static __thread const char *s1 = "s1"; > > produces a dynamic relocation against .tdata in a -pie build, which can > have caught the regression. thanks committed