[PATCH libc-test] add utime (utimensat, futimens) functional tests

[Rich Felker <dalias@libc.org>]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Here's a WIP (may extend later but seems good as-is too) utime test
for libc-test. I've been using it to test the upcoming time64
functionality for 32-bit archs.

Rich

[-- Attachment #2: 0001-add-utime-utimensat-futimens-functional-tests.patch --]
[-- Type: text/plain, Size: 3453 bytes --]

From abffbd450401c6638177c0bc7b789130e41c1e84 Mon Sep 17 00:00:00 2001
From: Rich Felker <dalias@aerifal.cx>
Date: Thu, 22 Aug 2019 20:58:00 -0400
Subject: [PATCH] add utime (utimensat, futimens) functional tests

these tests check for the ability to set file timestamps using
UTIME_NOW, UTIME_OMIT, and explicit timespecs. they indirectly check
that fstat works as well, and include a check of the first Y2038
timestamp that overflows 32-bit time_t, reporting errors for a Y2038
EOL implementaton (if time_t is 32-bit) or a kernel, filesystem, or
library implementation that fails to set and read back timestamps past
the 32-bit limit despite having a time_t type that can represent such
a timestamp.
---
 src/functional/utime.c | 73 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 src/functional/utime.c

diff --git a/src/functional/utime.c b/src/functional/utime.c
new file mode 100644
index 0000000..7fa7a1f
--- /dev/null
+++ b/src/functional/utime.c
@@ -0,0 +1,73 @@
+#include <sys/stat.h>
+#include <errno.h>
+#include <string.h>
+#include <stdio.h>
+#include <time.h>
+#include <stdint.h>
+#include <unistd.h>
+#include <fcntl.h>
+#include "test.h"
+
+#define TEST(c, ...) ((c) ? 1 : (t_error(#c" failed: " __VA_ARGS__),0))
+#define TESTVAL(v,op,x) TEST(v op x, "%jd\n", (intmax_t)(v))
+
+int main(void)
+{
+	struct stat st;
+	FILE *f;
+	int fd;
+	time_t t;
+
+	TEST(utimensat(AT_FDCWD, "/dev/null/invalid", ((struct timespec[2]){{.tv_nsec=UTIME_OMIT},{.tv_nsec=UTIME_OMIT}}), 0)==0 || errno==ENOTDIR,
+		"%s\n", strerror(errno));
+	TEST(futimens(-1, ((struct timespec[2]){{.tv_nsec=UTIME_OMIT},{.tv_nsec=UTIME_OMIT}}))==0 || errno==EBADF,
+		"%s\n", strerror(errno));
+
+	if (!TEST(f = tmpfile())) return t_status;
+	fd = fileno(f);
+
+	TEST(futimens(fd, (struct timespec[2]){0}) == 0, "\n");
+	TEST(fstat(fd, &st) == 0, "\n");
+	TESTVAL(st.st_atim.tv_sec,==,0);
+	TESTVAL(st.st_atim.tv_nsec,==,0);
+	TESTVAL(st.st_mtim.tv_sec,==,0);
+	TESTVAL(st.st_mtim.tv_nsec,==,0);
+
+	TEST(futimens(fd, ((struct timespec[2]){{.tv_sec=1,.tv_nsec=UTIME_OMIT},{.tv_sec=1,.tv_nsec=UTIME_OMIT}})) == 0, "\n");
+	TEST(fstat(fd, &st) == 0, "\n");
+	TESTVAL(st.st_atim.tv_sec,==,0);
+	TESTVAL(st.st_atim.tv_nsec,==,0);
+	TESTVAL(st.st_mtim.tv_sec,==,0);
+	TESTVAL(st.st_mtim.tv_nsec,==,0);
+
+	t = time(0);
+
+	TEST(futimens(fd, ((struct timespec[2]){{.tv_nsec=UTIME_NOW},{.tv_nsec=UTIME_OMIT}})) == 0, "\n");
+	TEST(fstat(fd, &st) == 0, "\n");
+	TESTVAL(st.st_atim.tv_sec,>=,t);
+	TESTVAL(st.st_mtim.tv_sec,==,0);
+	TESTVAL(st.st_mtim.tv_nsec,==,0);
+	
+	TEST(futimens(fd, (struct timespec[2]){0}) == 0, "\n");
+	TEST(futimens(fd, ((struct timespec[2]){{.tv_nsec=UTIME_OMIT},{.tv_nsec=UTIME_NOW}})) == 0, "\n");
+	TEST(fstat(fd, &st) == 0, "\n");
+	TESTVAL(st.st_atim.tv_sec,==,0);
+	TESTVAL(st.st_mtim.tv_sec,>=,t);
+
+	TEST(futimens(fd, ((struct timespec[2]){{.tv_nsec=UTIME_NOW},{.tv_nsec=UTIME_OMIT}})) == 0, "\n");
+	TEST(fstat(fd, &st) == 0, "\n");
+	TESTVAL(st.st_atim.tv_sec,>=,t);
+	TESTVAL(st.st_mtim.tv_sec,>=,t);
+
+	if (TEST((time_t)(1LL<<32) == (1LL<<32), "implementation has Y2038 EOL\n")) {
+		if (TEST(futimens(fd, ((struct timespec[2]){{.tv_sec=1LL<<32},{.tv_sec=1LL<<32}})) == 0, "%s\n", strerror(errno))) {
+			TEST(fstat(fd, &st) == 0, "\n");
+			TESTVAL(st.st_atim.tv_sec, ==, 1LL<<32);
+			TESTVAL(st.st_mtim.tv_sec, ==, 1LL<<32);
+		}
+	}
+
+	fclose(f);
+
+	return t_status;
+}
-- 
2.21.0