mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Allow %lf in wprintf
Date: Fri, 13 Sep 2019 14:06:48 -0400	[thread overview]
Message-ID: <20190913180648.GH9017@brightrain.aerifal.cx> (raw)
In-Reply-To: <CA+30r1RSrkZyHszSGu9VFL=ZdrokazRPQfZbH3puYSdX-PaWig@mail.gmail.com>

On Wed, Sep 11, 2019 at 11:09:03PM -0700, Brion Vibber wrote:
> On the emscripten mailing list we got a report that using %lf as a format
> specifier for doubles worked in printf but not wprintf, which I was able to
> confirm looking at the musl implementation we're using.
> 
> It looks like support for %lf in printf was added in 2012 in
> commit cc3a44666, but didn't get copied to the wprintf implementation so
> they're just out of sync. I've attached a small patch which copies the same
> fix to the wprintf side.

Thanks! Applying.

> Please let me know if there's any test cases I should add to, or anything
> else. Thanks!

Coverage for wide printf in libc-test is probably poor. Please feel
free (but not obligated) to submit either a regression test for this
specific bug or some general functionality tests covering this case
and others. You can submit libc-test patches on the musl list too.

Rich


      reply	other threads:[~2019-09-13 18:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  6:09 Brion Vibber
2019-09-13 18:06 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913180648.GH9017@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).