mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] arm: avoid conditional branch to PLT in sigsetjmp.s
@ 2019-09-18  6:04 Andre McCurdy
  2019-09-18 14:28 ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Andre McCurdy @ 2019-09-18  6:04 UTC (permalink / raw)
  To: musl; +Cc: Andre McCurdy

The R_ARM_THM_JUMP19 relocation type generated for the original code
when targeting Thumb 2 is not supported by the gold linker:

 | .../arm-oe-linux-musleabi/9.2.0/ld: error: conditional branch to PLT in THUMB-2 not supported yet.
 | src/signal/arm/sigsetjmp.s:9: error: unexpected opcode while processing relocation R_ARM_THM_JUMP19
---
 src/signal/arm/sigsetjmp.s | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/signal/arm/sigsetjmp.s b/src/signal/arm/sigsetjmp.s
index 318addba..69ebbf49 100644
--- a/src/signal/arm/sigsetjmp.s
+++ b/src/signal/arm/sigsetjmp.s
@@ -6,9 +6,10 @@
 sigsetjmp:
 __sigsetjmp:
 	tst r1,r1
-	beq setjmp
+	bne 1f
+	b setjmp
 
-	str lr,[r0,#256]
+1:	str lr,[r0,#256]
 	str r4,[r0,#260+8]
 	mov r4,r0
 
-- 
2.23.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-07 18:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18  6:04 [PATCH] arm: avoid conditional branch to PLT in sigsetjmp.s Andre McCurdy
2019-09-18 14:28 ` Khem Raj
2019-09-18 17:52   ` Andre McCurdy
2019-09-18 19:54     ` Rich Felker
2019-11-21 20:54       ` Andre McCurdy
2019-12-07 18:03         ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).